Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: removed the extra $ sign appearing on the popup in workspaces tab #1348

Merged

Conversation

poswalsameer
Copy link
Contributor

Description:
This PR solves the issue of extra $ sign showing in the popup in the workspaces tab. The issue was pretty basic, just needed to go through the codebase to find the exact codefile where this thing is mentioned, removed the $ signs from there, and that's it.

Issue Fixed: #1340

Screenshots:
Screenshot (98)

@carlosvirreira
Copy link
Contributor

carlosvirreira commented Oct 11, 2024

Thank you for the contribution man! Would love to see you more around here and if you are not on Discord. Would be epic if you join us there!

@DonKoko
Copy link
Contributor

DonKoko commented Oct 11, 2024

Thanks @poswalsameer

@DonKoko DonKoko merged commit b4b422d into Shelf-nu:main Oct 11, 2024
4 checks passed
@poswalsameer
Copy link
Contributor Author

Thank you for the contribution man! Would love to see you more around here and if you are not on Discord. Would be epic if you join us there!

Thanks a lot for responding. It is my pleasure to contribute to Shelf, and yeah I am joining Discord now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants