Skip to content

Commit

Permalink
feat: set username to avatar alt attribute
Browse files Browse the repository at this point in the history
  • Loading branch information
MasterHiei authored and booxood committed Jul 13, 2019
1 parent 7adbf30 commit ed28542
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/component/avatar.jsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react'

export default ({ src, className }) => (
export default ({ src, className, alt }) => (
<div className={`gt-avatar ${className}`}>
<img src={src} alt="头像"/>
<img src={src} alt={alt}/>
</div>
)
6 changes: 6 additions & 0 deletions src/component/avatar.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,11 @@ describe('Avatar', function () {
.find('img').prop('src')
).toEqual(src)
})
it('set props alt', function () {
const alt = 'alt'
expect(shallow(<Avatar alt={alt} />)
.find('img').prop('alt')
).toEqual(alt)
})
})

1 change: 1 addition & 0 deletions src/component/comment.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export default class Comment extends Component {
<Avatar
className="gt-comment-avatar"
src={comment.user && comment.user.avatar_url}
alt={`@${comment.user && comment.user.login}`}
/>

<div className="gt-comment-content">
Expand Down
2 changes: 1 addition & 1 deletion src/gitalk.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ class GitalkComponent extends Component {
return (
<div className="gt-header" key="header">
{user ?
<Avatar className="gt-header-avatar" src={user.avatar_url} /> :
<Avatar className="gt-header-avatar" src={user.avatar_url} alt={`@${user.login}`} /> :
<a className="gt-avatar-github" onMouseDown={this.handleLogin}>
<Svg className="gt-ico-github" name="github"/>
</a>
Expand Down

0 comments on commit ed28542

Please sign in to comment.