Enable include_config_on_deploy by default for new apps #5253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show files with reduced coverage 🔻
Test suite run success2002 tests passing in 904 suites. Report generated by 🧪jest coverage report action from 63192ff |
This comment has been minimized.
This comment has been minimized.
|
/snapit |
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by intalling your package globally: pnpm i -g @shopify/[email protected]
|
isaacroldan
reviewed
Jan 28, 2025
| @@ -116,32 +116,31 @@ describe('link', () => { | |||
| expect(remoteApp).toEqual(mockRemoteApp({developerPlatformClient})) | |||
| }) | |||
| }) | |||
| }) | |||
There was a problem hiding this comment.
was this change intentional? seems like it changed the indentation of all tests
There was a problem hiding this comment.
Yes, most of the tests here were outside of the describe where they should belong. Sorry for the noise 😅
isaacroldan
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
When you create a new app in Partners with
shopify app init, the generated TOML should includeinclude_config_on_deploy = true.It was working some time ago, but then broken when we added the authentication to the app init. The reason is that we were checking if the app is new to add that field, but after that refactor, we create the app first and then fetch it again when running link, so that the
newAppproperty was missed.WHAT is this pull request doing?
The link function is already receiving a
newAppoption, so I'm just setting it again to the returned app if required.How to test your changes?
npm i -g @shopify/[email protected]shopify app initinclude_config_on_deploy = trueshopify app deploydoesn't ask about including the configMeasuring impact
How do we know this change was effective? Please choose one:
Checklist