Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete deprecate-shopify-cli-extensions.yml #5261

Merged

Conversation

gonzaloriestra
Copy link
Contributor

WHY are these changes introduced?

The workflow added in #5257 has already been triggered and it worked, so we don't need it anymore

WHAT is this pull request doing?

Delete the already used workflow

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@gonzaloriestra gonzaloriestra requested a review from a team as a code owner January 23, 2025 11:37
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.32% 8889/11801
🟡 Branches 70.56% 4322/6125
🟡 Functions 75.1% 2337/3112
🟡 Lines
75.86% (+0.01% 🔼)
8401/11074
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
93.83% (-1.23% 🔻)
86.49% (-2.7% 🔻)
90.48% 98.61%

Test suite run success

2001 tests passing in 904 suites.

Report generated by 🧪jest coverage report action from 783fc3a

Copy link
Contributor Author

gonzaloriestra commented Jan 23, 2025

Merge activity

  • Jan 23, 7:12 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 23, 7:13 AM EST: A user added this pull request to the GitHub merge queue with Graphite.
  • Jan 23, 7:37 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 23, 7:38 AM EST: A user added this pull request to the GitHub merge queue with Graphite.

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2025
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit d4601ad Jan 23, 2025
26 checks passed
@gonzaloriestra gonzaloriestra deleted the remove-deprecate-shopify-cli-extensions-workflow branch January 23, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants