show error message in replay command when no logs available #5292
+35
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success2025 tests passing in 907 suites. Report generated by 🧪jest coverage report action from 61a1a10 |
jacobsteves
requested review from
a team,
lopert and
mssalemi
and removed request for
a team
andrewhassan
approved these changes
Jan 28, 2025
jacobsteves
force-pushed
the
js.show-error-message-when-no-logs-available
branch
2 times, most recently
from
fde6c46 to
714dbeb
Compare
mssalemi
approved these changes
Jan 28, 2025
lopert
approved these changes
Jan 28, 2025
jacobsteves
force-pushed
the
js.show-error-message-when-no-logs-available
branch
from
714dbeb to
61a1a10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/shopify-functions/issues/599
If someone tries to run the function replay command without having any logs existing, they get an ugly error message:
WHAT is this pull request doing?
Make that error nicer! If they directory doesn't exist, we can assume theres no logs. We already have nice error handling when theres no logs, but the directory exists.
How to test your changes?
rm -rf ~Library/Logs/shopify-cli-nodejspnpm shopify app function replay --path path_to_your_appPost-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist