Add Rails test command resolution #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails allows writing tests with the syntax `test "should do something"`, but internally converts these to standard Minitest method names `test_should_do_something`. This normalization ensures our test identifiers match what Rails uses at runtime, allowing proper test discovery and execution.
alexcrocha
force-pushed
the
ar/command-resolution
branch
from
465c4a5 to
9d04fcb
Compare
st0012
reviewed
Apr 24, 2025
| )) | ||
| end | ||
| elsif tags.include?("test_file") | ||
| full_files << path if children.empty? |
There was a problem hiding this comment.
What happens when the children is not empty?
There was a problem hiding this comment.
We continue to concat the children into the queue. But if the children are empty, that indicates that we are trying to run that entire file and so we must append it to full_files.
vinistock
approved these changes
Apr 24, 2025
| )) | ||
| end | ||
| elsif tags.include?("test_file") | ||
| full_files << path if children.empty? |
There was a problem hiding this comment.
We continue to concat the children into the queue. But if the children are empty, that indicates that we are trying to run that entire file and so we must append it to full_files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Shopify/ruby-lsp#3179, closes Shopify/ruby-lsp#3170
This PR builds on #591’s test discovery support by generating test commands for Rails tests discovered in VS Code’s Test Explorer.
Before
Tests defined via
test "…"appeared in the explorer, but clicking Run did nothing as no command was emitted.After
Now clicking Run emits the exact
bin/rails test …command Rails uses at runtime.Added command resolution for:
Dir.globon*_test.rb/test_*.rb--name "/GroupTest(#|::)/"file:lineentriesFor this to work, we normalize string-based test names (e.g.,
"should do something") by prefixingtest_and replacing spaces with underscores (test_#{test_name.gsub(/\s+/, '_')}), matching Rails' ownActiveSupport::Testing::Declarative#testhelper. This ensures our test IDs line up with the methods Rails actually runs (e.g.,test_should_do_something).