Add Region#tax_type accessor, cut v1.14.0 #300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Region ymls contain data on the zone tax_types
worldwide/db/data/regions/CA.yml
Lines 121 to 122 in dc40ce8
This PR makes the tax type available via the Region object.
Also cuts version
1.14.0
.What approach did you choose and why?
Added region territory accessor for tax_type. Unlike tax_name and tax_rate, the tax_type is only defined on the territory or zone level.
What should reviewers focus on?
...
The impact of these changes
on a country-level region, returns nil
Checklist