Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering font size and overline position. #326

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Fix rendering font size and overline position. #326

merged 1 commit into from
Mar 16, 2023

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes a regression where the current run font size was not being used for rendering. Also fixed overline position to match CSS

@JimBobSquarePants
Copy link
Member Author

I've already directly tested this locally against SixLabors/ImageSharp.Drawing#211

@JimBobSquarePants JimBobSquarePants merged commit 2a7c8a9 into main Mar 16, 2023
@JimBobSquarePants JimBobSquarePants deleted the js/fix-font-size branch March 16, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JimBobSquarePants