Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always create new text run, don't assume behavior. #420

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Always create new text run, don't assume behavior. #420

merged 2 commits into from
Oct 30, 2024

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #412 to always create a new text run rather than assuming a mistake on the user part.

@JimBobSquarePants JimBobSquarePants merged commit 5767254 into main Oct 30, 2024
8 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/fix-412 branch October 30, 2024 09:29
@tocsoft tocsoft mentioned this pull request Dec 10, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tocsoft tocsoft tocsoft approved these changes

@brianpopow brianpopow Awaiting requested review from brianpopow

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RichTextRun.End behaves as an inclusive index only when it is the same as the end of the string
2 participants
@JimBobSquarePants @tocsoft