Merge pull request cx-org#83 from cx-org/filter-in-place

Clean up storage of ObservableObjectPublisherCache in place.
Sixt · Jun 18, 2020 · 1b97107 · 1b97107
2 parents 9ce154b + a502288
commit 1b97107
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Sources/CombineX/Internal/ObserableObjectCache.swift b/Sources/CombineX/Internal/ObserableObjectCache.swift
@@ -12,8 +12,8 @@ class ObservableObjectPublisherCache<Key: AnyObject, Value: AnyObject> {
     private var lock = Lock()
 
     private func cleanup() {
-        storage = storage.filter { key, value in
-            return key.value != nil && value.value != nil
+        for (key, value) in storage where key.value == nil || value.value == nil {
+            storage.removeValue(forKey: key)
         }
     }