-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernized App #17
Open
Lichtblitz
wants to merge
46
commits into
SkyJedi:master
Choose a base branch
from
Lichtblitz:main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Modernized App #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - upgrading dependencies; fixing breaking changes - functional paradigm used to make components less verbose - switched from plain CSS to bootstrap - switched popups to bootstrap modals to kick out an outdated dependency - switched to SCSS to adjust the default bootstrap theme to make it look closer to the previous App version - overhauled the login page form and introduced (opt-in) cookies to remember values - migrated deprecated refs-API for react properties - everything that's clickable now acts like a button to make it very clear to the user what's interactable - all sections can now be minimized to show only the most important information/controls - slightly changed the order of the dice to always have a consistent theme in each row - messages and chats are color coded - message for resetting the destiny pool now contains the previous state - rolling brings the result automatically into view; most likely only relevant for small screens, for example on mobile - creating and editing a character now happens inside the character block, not inside a separate modal - added a few animations Bugfixes: - two edge cases where undefined fields were accessed - initiative tracker now works with a single entry as well
Closed
Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.11.3 to 6.11.4. - [Release notes](https://github.com/protobufjs/protobuf.js/releases) - [Changelog](https://github.com/protobufjs/protobuf.js/blob/master/CHANGELOG.md) - [Commits](https://github.com/protobufjs/protobuf.js/commits) --- updated-dependencies: - dependency-name: protobufjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Added GitHub Actions
Bumps [react-cookie](https://github.com/bendotcodes/cookies) from 4.1.1 to 6.0.1. - [Release notes](https://github.com/bendotcodes/cookies/releases) - [Changelog](https://github.com/bendotcodes/cookies/blob/main/LEGACY-CHANGELOG.md) - [Commits](https://github.com/bendotcodes/cookies/commits/v6.0.1) --- updated-dependencies: - dependency-name: react-cookie dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…ookie-6.0.1 Bump react-cookie from 4.1.1 to 6.0.1
Bumps [universal-cookie](https://github.com/bendotcodes/cookies) from 4.0.4 to 6.0.1. - [Release notes](https://github.com/bendotcodes/cookies/releases) - [Changelog](https://github.com/bendotcodes/cookies/blob/main/LEGACY-CHANGELOG.md) - [Commits](bendotcodes/cookies@v4.0.4...v6.0.1) --- updated-dependencies: - dependency-name: universal-cookie dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…al-cookie-6.0.1 Bump universal-cookie from 4.0.4 to 6.0.1
…fjs-6.11.4 Bump protobufjs from 6.11.3 to 6.11.4
Bumps [sass](https://github.com/sass/dart-sass) from 1.64.2 to 1.66.1. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.64.2...1.66.1) --- updated-dependencies: - dependency-name: sass dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…66.1 Bump sass from 1.64.2 to 1.66.1
Bumps [firebase](https://github.com/firebase/firebase-js-sdk) from 8.10.1 to 10.2.0. - [Release notes](https://github.com/firebase/firebase-js-sdk/releases) - [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/CHANGELOG.md) - [Commits](https://github.com/firebase/firebase-js-sdk/compare/[email protected]@10.2.0) --- updated-dependencies: - dependency-name: firebase dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…e-10.2.0 Bump firebase from 8.10.1 to 10.2.0
Fixed valid linting findings
Fixing a major XSS vulnerability
Bumps [react-cookie](https://github.com/bendotcodes/cookies) from 6.0.1 to 6.1.0. - [Release notes](https://github.com/bendotcodes/cookies/releases) - [Changelog](https://github.com/bendotcodes/cookies/blob/main/LEGACY-CHANGELOG.md) - [Commits](bendotcodes/cookies@v6.0.1...v6.1.0) --- updated-dependencies: - dependency-name: react-cookie dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [firebase](https://github.com/firebase/firebase-js-sdk) from 10.2.0 to 10.3.1. - [Release notes](https://github.com/firebase/firebase-js-sdk/releases) - [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/CHANGELOG.md) - [Commits](https://github.com/firebase/firebase-js-sdk/compare/[email protected]@10.3.1) --- updated-dependencies: - dependency-name: firebase dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [universal-cookie](https://github.com/bendotcodes/cookies) from 6.0.1 to 6.1.0. - [Release notes](https://github.com/bendotcodes/cookies/releases) - [Changelog](https://github.com/bendotcodes/cookies/blob/main/LEGACY-CHANGELOG.md) - [Commits](bendotcodes/cookies@v6.0.1...v6.1.0) --- updated-dependencies: - dependency-name: universal-cookie dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…cookie-6.1.0', 'origin/dependabot/npm_and_yarn/universal-cookie-6.1.0' and 'origin/dependabot/npm_and_yarn/firebase-10.3.1'
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 6.1.1 to 6.1.2. - [Release notes](https://github.com/testing-library/jest-dom/releases) - [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md) - [Commits](testing-library/jest-dom@v6.1.1...v6.1.2) --- updated-dependencies: - dependency-name: "@testing-library/jest-dom" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…g-library/jest-dom-6.1.2 Bump @testing-library/jest-dom from 6.1.1 to 6.1.2
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [universal-cookie](https://github.com/bendotcodes/cookies) from 6.1.0 to 6.1.1. - [Release notes](https://github.com/bendotcodes/cookies/releases) - [Changelog](https://github.com/bendotcodes/cookies/blob/main/LEGACY-CHANGELOG.md) - [Commits](bendotcodes/cookies@v6.1.0...v6.1.1) --- updated-dependencies: - dependency-name: universal-cookie dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [react-cookie](https://github.com/bendotcodes/cookies) from 6.1.0 to 6.1.1. - [Release notes](https://github.com/bendotcodes/cookies/releases) - [Changelog](https://github.com/bendotcodes/cookies/blob/main/LEGACY-CHANGELOG.md) - [Commits](bendotcodes/cookies@v6.1.0...v6.1.1) --- updated-dependencies: - dependency-name: react-cookie dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 6.1.2 to 6.1.3. - [Release notes](https://github.com/testing-library/jest-dom/releases) - [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md) - [Commits](testing-library/jest-dom@v6.1.2...v6.1.3) --- updated-dependencies: - dependency-name: "@testing-library/jest-dom" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…sal-cookie-6.1.1' and 'origin/dependabot/npm_and_yarn/react-cookie-6.1.1'
…library/jest-dom-6.1.3'
counting symbols instead of displaying them all
Added expand/collapse button to the Messages component to enable
Bumps [sass](https://github.com/sass/dart-sass) from 1.66.1 to 1.67.0. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.66.1...1.67.0) --- updated-dependencies: - dependency-name: sass dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
….67.0 Bump sass from 1.66.1 to 1.67.0
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 5.3.1 to 5.3.2. - [Release notes](https://github.com/twbs/bootstrap/releases) - [Commits](twbs/bootstrap@v5.3.1...v5.3.2) --- updated-dependencies: - dependency-name: bootstrap dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…rap-5.3.2 Bump bootstrap from 5.3.1 to 5.3.2
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event) from 14.4.3 to 14.5.1. - [Release notes](https://github.com/testing-library/user-event/releases) - [Changelog](https://github.com/testing-library/user-event/blob/main/CHANGELOG.md) - [Commits](testing-library/user-event@v14.4.3...v14.5.1) --- updated-dependencies: - dependency-name: "@testing-library/user-event" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…g-library/user-event-14.5.1 Bump @testing-library/user-event from 14.4.3 to 14.5.1
Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 29.5.4 to 29.5.5. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) --- updated-dependencies: - dependency-name: "@types/jest" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…jest-29.5.5 Bump @types/jest from 29.5.4 to 29.5.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi SkyJedi :-)
Try out my changes at https://dice.istbeiuns.de/
PR #16 got closed because I renamed my main branch.
I have been a long time user of your dice roller and had the idea to spend some time and effort to modernize the app as a form of give-back. My primary goal was to improve the user interface, especially on smaller screens. I think it's ready for public scrutiny. Please let me know what you think.
If you decide to accept the PR and host it yourself, I will take down my demo page, which I have temprarily connected to the same firebase-db in order to better compare before/after.
Changes:
Bugfixes: