Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make MissingValueForParameter a 400 error #1778

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Feb 17, 2025

Important

MissingValueForParameter now returns a 400 status code for missing parameter values in workflow runs.

  • Behavior:
    • MissingValueForParameter in exceptions.py now returns a 400 status code for missing parameter values in workflow runs.
  • Misc:
    • Added status_code=status.HTTP_400_BAD_REQUEST to MissingValueForParameter constructor.

This description was created by Ellipsis for b1282ff. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b1282ff in 24 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. skyvern/exceptions.py:156
  • Draft comment:
    Setting status_code to HTTP_400_BAD_REQUEST is correct and consistent with our convention. LGTM.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. skyvern/exceptions.py:156
  • Draft comment:
    Explicitly passing status_code clarifies that this exception returns HTTP 400. Since HTTP_400_BAD_REQUEST is the default in SkyvernHTTPException, this may be redundant, but it's clear and consistent with the intent.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None

Workflow ID: wflow_TtgfCwRI9lkWKoX0


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit 0116f56 into main Feb 17, 2025
7 checks passed
@wintonzheng wintonzheng deleted the shu/MissingValueForParameter_400_error branch February 17, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant