Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sldss 27892 tqc ref do not work properly #159

Merged
merged 10 commits into from
Nov 11, 2021

Conversation

achebanets
Copy link
Contributor

@achebanets achebanets commented Nov 9, 2021

The problem is: we use latest version of ReDoc. Latest version doesn't support the directive $ref the second level (we use it for TQC endpoint description). So the script resolve the $ref and replace with the certain value.

@@ -0,0 +1,53 @@
const yaml = require('js-yaml');
const fs = require('fs');
const { Resolver } = require('@stoplight/json-ref-resolver');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

console.log("-----------------------------------------------------------");
console.log(resolved);
console.log("before resolved.result");
var destinationJson = {"x-paths": resolved.result}
Copy link

@azvoncov-smartling azvoncov-smartling Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let destinationJson = { "x-paths": resolved.result };

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@DmitryBochorishvili
Copy link
Collaborator

Could you describe what's the problem you're solving and what's the overall solution?
It's hard to get it from the changes itself

@DmitryBochorishvili
Copy link
Collaborator

Couple of questions:

  • should we add spec/.DS_Store to gitignore?
  • are there any changes required to travis build script for the project?

@achebanets
Copy link
Contributor Author

achebanets commented Nov 10, 2021

Couple of questions:

  • should we add spec/.DS_Store to gitignore?
  • are there any changes required to travis build script for the project?
  • DS_Store - removed
  • " travis build script " - it doesn't need any changes.

@achebanets achebanets closed this Nov 10, 2021
@achebanets achebanets reopened this Nov 10, 2021
@achebanets achebanets merged commit 5bdc532 into master Nov 11, 2021
@achebanets achebanets deleted the SLDSS-27892-tqc-ref-do-not-work-properly branch November 11, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants