Bump bitflags to v2

[daxpedda]

Changelog: https://github.com/bitflags/bitflags/blob/2.0.0/CHANGELOG.md#200.

This is a breaking change. The API that is implemented by the macro is now different.

We didn't really have to derive anything apart from Debug to make it work, but considering this is public I derived all other traits as well except PartialOrd, Ord and Default.

Fixes #622.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.12 🎉

Comparison is base (c032dd8) 73.38% compared to head (81c040d) 73.50%.

❗ Current head 81c040d differs from pull request most recent head 9f67f62. Consider uploading reports for the commit 9f67f62 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
+ Coverage   73.38%   73.50%   +0.12%     
==========================================
  Files          47       47              
  Lines        7672     7651      -21     
==========================================
- Hits         5630     5624       -6     
+ Misses       2042     2027      -15     

Flag	Coverage Δ
main	58.92% <ø> (+0.10%)	⬆️
test--	78.34% <ø> (-0.03%)	⬇️
test--server_system	61.64% <ø> (+0.15%)	⬆️
test-client_system-	69.34% <ø> (+0.02%)	⬆️
test-client_system-server_system	51.62% <ø> (+0.14%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
wayland-scanner/src/common.rs	95.72% <ø> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[daxpedda]

CI failure is actually an issue in calloop with minimal dependencies: Smithay/calloop#133.

[daxpedda]

What should I do here? Are older versions of calloop going to be yanked or should I just raise the minimum version of calloop?

[kchibisov]

I think we can move calloop integration into a separate crate entirely, so breaking change to calloop won't raise the wayland-client version? What do you think @elinorbgr ? That would simplify handling of the crate in my opinion.

We'd have breaking bumps of wayland-client, due to syn/bitflags update, so it looks like a good opportunity for a split.

[elinorbgr]

For this PR, just bump the calloop dependency to 0.10.6 (I released both 0.11 and 0.10.6, and both have the fix).

regarding calloop and wayland-client in general, I need to check back why we included them in the first place, and this is out of scope for this PR.

[daxpedda]

Done.

[kchibisov]

regarding calloop and wayland-client in general, I need to check back why we included them in the first place, and this is out of scope for this PR.

It was included because it was 1) common code which could be used by other libs outside of the client-toolkit, so the code from client toolkit moved up. 2) Yes, it's for other PR, but in general, I think it should be separate 1 file crate with just a source.