server: Verify that .lock fd matches on-disk file #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #632 +/- ##
==========================================
- Coverage 73.38% 73.34% -0.04%
==========================================
Files 47 47
Lines 7672 7680 +8
==========================================
+ Hits 5630 5633 +3
- Misses 2042 2047 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
YaLTeR
added a commit
to YaLTeR/wl-clipboard-rs
that referenced
this pull request
Jun 23, 2023
wayland-rs 0.30 is a major API redesign. This commit ports wl-clipboard-rs to use it. As a bonus, it fixes #1: the tests are now fully robust†. As an extra bonus, it adds several randomized property-based tests. Since this is a pretty major rewrite, I also took this opportunity to move to a more standard rustfmt config (Block indent style, default max width). Resolves #36. †: the tests can currently fail due to a race condition in wayland-rs, which will be automatically fixed when Smithay/wayland-rs#632 is merged.
|
Sorry for the late review. Thanks, this looks good. Could you just add a changelog entry for this? |
Fixes a race condition that can happen if one thread unlinks the .lock between our open() and flock() calls.
YaLTeR
force-pushed
the
fix-listening-socket-race
branch
from
31a1fd4
to
cd1157d
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition that can happen if one thread unlinks the .lock between our open() and flock() calls.