Skip to content

Commit

Permalink
Merge pull request apache#2343 from gianm/fix-lookups
Browse files Browse the repository at this point in the history
Fix a couple of problems with lookups
  • Loading branch information
b-slim committed Jan 27, 2016
2 parents cac6753 + b1e6c01 commit abf2f45
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public class NamespacedExtractor extends LookupExtractor
public NamespacedExtractor(
@NotNull @JacksonInject @Named("dimExtractionNamespace")
final Function<String, Function<String, String>> namespaces,
@NotNull @JacksonInject @Named("reverseDimExtractionNamespace")
@NotNull @JacksonInject @Named("dimReverseExtractionNamespace")
final Function<String, Function<String, List<String>>> reverseNamespaces,
@NotNull @JsonProperty(value = "namespace", required = true)
final String namespace
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public abstract class LookupExtractor
* @return The lookup, or null key cannot have the lookup applied to it and should be treated as missing.
*/
@Nullable
abstract String apply(@NotNull String key);
public abstract String apply(@NotNull String key);

/**
* @param keys set of keys to apply lookup for each element
Expand All @@ -54,7 +54,7 @@ public abstract class LookupExtractor
* User can override this method if there is a better way to perform bulk lookup
*/

Map<String, String> applyAll(Iterable<String> keys)
public Map<String, String> applyAll(Iterable<String> keys)
{
if (keys == null) {
return Collections.emptyMap();
Expand Down Expand Up @@ -88,7 +88,7 @@ Map<String, String> applyAll(Iterable<String> keys)
* User can override this method if there is a better way to perform bulk reverse lookup
*/

Map<String, List<String>> unapplyAll(Iterable<String> values)
public Map<String, List<String>> unapplyAll(Iterable<String> values)
{
if (values == null) {
return Collections.emptyMap();
Expand All @@ -107,5 +107,5 @@ Map<String, List<String>> unapplyAll(Iterable<String> values)
*/

@Nullable
abstract byte[] getCacheKey();
public abstract byte[] getCacheKey();
}

0 comments on commit abf2f45

Please sign in to comment.