Skip to content

Add node 18 deprecation warning to banner #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Add node 18 deprecation warning to banner #470

merged 1 commit into from
Apr 23, 2025

Conversation

pvdz
Copy link
Collaborator

@pvdz pvdz commented Apr 23, 2025

We should at least give people a heads up about it.

image

(Hm, this would cause the node 18 tests to break because snapshots. Can we maybe just turn that test runner off now in anticipation of the full deprecation?)

@pvdz pvdz requested a review from jdalton April 23, 2025 14:33
@jdalton
Copy link
Collaborator

jdalton commented Apr 23, 2025

Yes

@jdalton jdalton merged commit d5bc9a6 into main Apr 23, 2025
16 of 18 checks passed
@jdalton jdalton deleted the node18depwarn branch April 23, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants