Skip to content

Fix output; some was breaking --json, some typos #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 1, 2025
Merged

Conversation

pvdz
Copy link
Collaborator

@pvdz pvdz commented May 1, 2025

Some minor output fixes

  • various cases of logging to stdout that was breaking --json, temporarily doing an .error() but we'll change the logger soon to always output non-log commands to stderr and then we can do a sweep through the .error() calls to see what needs to be different.
  • Some textual changes and fixed some missing parenthesis in text (the bot caught one the other day but apparently didn't think it was important for the others)

@pvdz pvdz requested a review from jdalton May 1, 2025 08:55
@jdalton jdalton merged commit d2aa839 into main May 1, 2025
12 checks passed
@jdalton jdalton deleted the output_cleanup branch May 1, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants