Add constants.socketAppPath #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| constants.ENV.LOCALAPPDATA | ||
| : // Lazily access constants.ENV.XDG_DATA_HOME | ||
| constants.ENV.XDG_DATA_HOME | ||
| if (!dataHome) { |
There was a problem hiding this comment.
The LOCALAPPDATA variable is referenced in the template string but isn't defined in this scope. This will likely cause a reference error at runtime. Consider either:
- Using the fully qualified path:
constants.ENV.LOCALAPPDATA - Adding a local constant declaration before this code block
- Using a string literal if this is meant to be the literal environment variable name
This ensures the code will execute properly when this warning needs to be displayed.
Suggested change
| if (!dataHome) { | |
| logger.warn(`Missing %LOCALAPPDATA%`) |
Spotted by Diamond (based on custom rules)
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add constants.socketAppPath