Add --all to repos list, cleanup pagination ux #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never really looked into this but all these list commands have a pretty bad UX around pagination. In particular being notified whether there is more left to be fetched, or an ability to just batch-fetch them all. So this PR fixes that for the
socket repos listcommand. Should probably do this for all the others too (or at least where it makes sense, not for something like scans which may have any number).Now you can do
socket repos list --allto fetch all repos (up to 10k results).The result will also tell you more about the query, page state, and whether there is more data left to be fetched. It will also give you a hint on how to fetch the next page (we should do that more often).