Remove vendor

- Remove the vendor directory
- Update bot to stop accounting for vendor
- Update linter config
- Remove update-vendor make target

.github/workflows/robot/internal/bot/bot.go

@@ -94,9 +94,6 @@ func (b *Bot) parseChanges(ctx context.Context) (bool, bool, error) {
 }
 
 func hasDocs(filename string) bool {
-	if strings.HasPrefix(filename, "vendor/") {
-		return false
-	}
 	return strings.HasPrefix(filename, "docs/") ||
 		strings.HasSuffix(filename, ".md") ||
 		strings.HasSuffix(filename, ".mdx") ||

.github/workflows/robot/internal/bot/label.go

@@ -62,11 +62,6 @@ func (b *Bot) labels(ctx context.Context) ([]string, error) {
 	}
 
 	for _, file := range files {
-		// Special case: skip vendor until it is removed in #9545.
-		if strings.HasPrefix(file, "vendor/") {
-			continue
-		}
-
 		for k, v := range prefixes {
 			if strings.HasPrefix(file, k) {
 				log.Printf("Label: Found prefix %v, attaching labels: %v.", k, v)

.golangci.yml

@@ -32,7 +32,5 @@ output:
   uniq-by-line: false
 
 run:
-  skip-dirs:
-    - vendor
   skip-dirs-use-default: false
   timeout: 5m

CONTRIBUTING.md

@@ -19,4 +19,4 @@ If your patch depends on new packages, the dependencies must:
 
 - be licensed via Apache2 license
 - be approved by core Teleport contributors ahead of time
-- a dependency package must be vendored as a [Go module](https://blog.golang.org/using-go-modules)
+- a dependency package must be a [Go module](https://blog.golang.org/using-go-modules)

Makefile

@@ -464,7 +464,7 @@ test: test-sh test-api test-go
 test-go: ensure-webassets bpf-bytecode roletester rdpclient $(RENDER_TESTS)
 test-go: FLAGS ?= '-race'
 test-go: PACKAGES := $(shell go list ./... | grep -v integration)
-test-go: CHAOS_FOLDERS := $(shell find . -type f -name '*chaos*.go' -not -path '*/vendor/*' | xargs dirname | uniq)
+test-go: CHAOS_FOLDERS := $(shell find . -type f -name '*chaos*.go' | xargs dirname | uniq)
 test-go: $(VERSRC)
 	$(CGOFLAG) go test -cover -json -tags "$(PAM_TAG) $(FIPS_TAG) $(BPF_TAG) $(ROLETESTER_TAG) $(RDPCLIENT_TAG)" $(PACKAGES) $(FLAGS) $(ADDFLAGS) \
 		| ${RENDER_TESTS}
@@ -560,7 +560,7 @@ lint-api:
 .PHONY: lint-sh
 lint-sh: SH_LINT_FLAGS ?=
 lint-sh:
-	find . -type f -name '*.sh' | grep -v vendor | xargs \
+	find . -type f -name '*.sh' | xargs \
 		shellcheck \
 		--exclude=SC2086 \
 		$(SH_LINT_FLAGS)
@@ -620,7 +620,6 @@ ADDLICENSE_ARGS := -c 'Gravitational, Inc' -l apache \
 		-ignore 'e/**' \
 		-ignore 'gitref.go' \
 		-ignore 'lib/web/build/**' \
-		-ignore 'vendor/**' \
 		-ignore 'version.go' \
 		-ignore 'webassets/**' \
 		-ignore 'ignoreme' \
@@ -661,7 +660,6 @@ $(VERSRC): Makefile
 .PHONY: update-api-module-path
 update-api-module-path:
 	go run build.assets/update_api_module_path/main.go -tags "bpf fips pam roletester desktop_access_rdp"
-	$(MAKE) update-vendor
 	$(MAKE) grpc
 
 # make tag - prints a tag to use with git for the current version
@@ -711,7 +709,7 @@ profile:
 
 .PHONY: sloccount
 sloccount:
-	find . -path ./vendor -prune -o -name "*.go" -print0 | xargs -0 wc -l
+	find . -o -name "*.go" -print0 | xargs -0 wc -l
 
 .PHONY: remove-temp-files
 remove-temp-files:
@@ -942,31 +940,6 @@ init-submodules-e: init-webapps-submodules-e
 	git submodule init e
 	git submodule update
 
-# Update go.mod and vendor files.
-.PHONY: update-vendor
-update-vendor:
-	# update modules in api/
-	cd api && go mod tidy
-	# update modules in root directory
-	go mod tidy
-	go mod vendor
-	$(MAKE) vendor-api
-
-# When teleport vendors its dependencies, Go also vendors the local api sub module. To get
-# around this issue, we replace the vendored api package with a symlink to the
-# local module. The symlink should be in vendor/.../api or vendor/.../api/vX if X >= 2.
-.PHONY: vendor-api
-vendor-api: API_VENDOR_PATH := vendor/$(shell head -1 api/go.mod | awk '{print $$2;}')
-vendor-api:
-	rm -rf vendor/github.com/gravitational/teleport/api
-	mkdir -p $(shell dirname $(API_VENDOR_PATH))
-	# make a relative link to the true api dir (without using `ln -r` for non-linux OS compatibility)
-	if [ -d $(shell dirname $(API_VENDOR_PATH))/../../../../../api/ ]; then \
-		ln -s ../../../../../api $(API_VENDOR_PATH); \
-	else \
-		ln -s ../../../../api $(API_VENDOR_PATH); \
-	fi;
-
 # update-webassets updates the minified code in the webassets repo using the latest webapps
 # repo and creates a PR in the teleport repo to update webassets submodule.
 .PHONY: update-webassets

README.md

@@ -35,7 +35,7 @@
 
 ## Introduction
 
-Teleport is the easiest, most secure way to access all your infrastructure. 
+Teleport is the easiest, most secure way to access all your infrastructure.
 Teleport is an identity-aware, multi-protocol access proxy which understands
 SSH, HTTPS, RDP, Kubernetes API, MySQL, MongoDB and PostgreSQL wire protocols.
 
@@ -209,43 +209,27 @@ Latest version:
 go get github.com/new/dependency
 ```
 
-Update the source to use this dependency, then run:
+and update the source to use this dependency.
 
-```bash
-make update-vendor
-```
-
-Specific version:
-
-```bash
-go get github.com/new/dependency@version
-```
-
-Update the source to use this dependency, then run:
 
-```bash
-make update-vendor
-```
+To get a specific version, use `go get github.com/new/dependency@version` instead.
 
 #### Set dependency to a specific version
 
 ```bash
 go get github.com/new/dependency@version
-make update-vendor
 ```
 
 #### Update dependency to the latest version
 
 ```bash
 go get -u github.com/new/dependency
-make update-vendor
 ```
 
 #### Update all dependencies
 
 ```bash
 go get -u all
-make update-vendor
 ```
 
 #### Debugging dependencies
@@ -297,5 +281,5 @@ You can find the latest stable Teleport build on our [Releases](https://gotelepo
 ## Who Built Teleport?
 
 Teleport was created by [Gravitational Inc](https://goteleport.com). We have
-built Teleport by borrowing from our previous experiences at Rackspace. [Learn more 
+built Teleport by borrowing from our previous experiences at Rackspace. [Learn more
 about Teleport and our history](https://goteleport.com/about/).

build.assets/Dockerfile

@@ -131,9 +131,7 @@ RUN (git clone https://github.com/gogo/protobuf.git ${GOPATH}/src/github.com/gog
      git reset --hard ${GOGO_PROTO_TAG} && \
      make install)
 
-# Note: protoc reads the proto files from /vendor/.../teleport/api/vX rather than
-# /api because protoc does not understand go modules, and reads vX as a directory.
-ENV PROTO_INCLUDE "/usr/local/include":"/go/src/github.com/gravitational/teleport/vendor":"/go/src/github.com/gogo/protobuf/protobuf":"${GOGOPROTO_ROOT}":"${GOGOPROTO_ROOT}/protobuf"
+ENV PROTO_INCLUDE "/usr/local/include":"/go/src":"/go/src/github.com/gogo/protobuf/protobuf":"${GOGOPROTO_ROOT}":"${GOGOPROTO_ROOT}/protobuf"
 
 # Install PAM module and policies for testing.
 COPY pam/ /opt/pam_teleport/

build.assets/Dockerfile-devbox

@@ -59,9 +59,7 @@ RUN (git clone https://github.com/gogo/protobuf.git ${GOPATH}/src/github.com/gog
      git reset --hard ${GOGO_PROTO_TAG} && \
      make install)
 
-# Note: protoc reads the proto files from /vendor/.../teleport/api/vX rather than
-# /api because protoc does not understand go modules, and reads vX as a directory.
-ENV PROTO_INCLUDE "/usr/local/include":"/go/src/github.com/gravitational/teleport/vendor":"/go/src/github.com/gogo/protobuf/protobuf":"${GOGOPROTO_ROOT}":"${GOGOPROTO_ROOT}/protobuf"
+ENV PROTO_INCLUDE "/usr/local/include":"/go/src":"/go/src/github.com/gogo/protobuf/protobuf":"${GOGOPROTO_ROOT}":"${GOGOPROTO_ROOT}/protobuf"
 
 USER root
 VOLUME ["/go/src/github.com/gravitational/teleport"]

docs/preflight.md

@@ -2,9 +2,9 @@
 
 This checklist is to be run prior to cutting the release branch.
 
-- [ ] Bump Golang vendor dependencies
+- [ ] Bump Golang dependencies
 - [ ] Review forked dependencies for upstream security patches
-- [ ] Bump Web UI vendor dependencies
+- [ ] Bump Web UI dependencies
 - [ ] Make a new docs/VERSION folder
 - [ ] Update VERSION in Makefile to next dev tag
 - [ ] Update TELEPORT_VERSION in assets/aws/Makefile