SONARJAVA-5256 Fix false positives on S2699 for AssertJ assertions

[romainbrenguier]

SONARJAVA-5256

There are many methods that can be used to write assertions with AssertJ. The previous pattern was only recognizing a couple of assertJ classes.
With this PR we generalize the pattern for recognizing AssertJ assertion methods so that it applies to many of these classes.

[alban-auzeill]

Sorry, I didn't look enough carefully during the first review. I forgot to suggest:

---

• Try to move computation in the static field as much as possible (executed only once) instead of during each method invocation (executed millions of times).

So I would call asMatchPredicate() in the static field initialization:

Suggested change

	@VisibleForTesting
	static final Pattern ASSERTJ_ASSERTION_METHODS_PATTERN = Pattern.compile(
	"(allMatch|assert|contains|doesNot|has|is|returns|satisfies)([A-Z].*)?");
	@VisibleForTesting
	static final Predicate<String> ASSERTJ_ASSERTION_METHODS_PREDICATE = Pattern.compile(
	"(allMatch|assert|contains|doesNot|has|is|returns|satisfies)([A-Z].*)?").asMatchPredicate();

---

• Never use the String#matches(String) that will call several times Pattern.compile.

We could have the following predicate:

  private static final Pattern ASSERTJ_ASSERTION_CLASSNAME_PATTERN = Pattern.compile(
    "org\\.assertj\\.core\\.api\\.[a-zA-Z]+Assert");

  private static final Predicate<Type> ASSERTJ_ASSERTION_TYPE_PREDICATE =
    type -> ASSERTJ_ASSERTION_CLASSNAME_PATTERN.matcher(type.fullyQualifiedName()).matches();

So we can replace:

MethodMatchers.create().ofType(type -> type.fullyQualifiedName().matches("org\\.assertj\\.core\\.api\\.[a-zA-Z]+Assert"))

with

MethodMatchers.create().ofType(ASSERTJ_ASSERTION_TYPE_PREDICATE)

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[alban-auzeill]

Thank you for the changes!