Skip to content

Commit

Permalink
Merge tag 'auxdisplay-for-linus-v4.19' of git://github.com/ojeda/linux
Browse files Browse the repository at this point in the history
Pull auxdisplay updates from Miguel Ojeda:
 "Two cleanups for char_lcd:

   - simplify getting .drvdata (Wolfram Sang)

   - delete mdelay in long_sleep (Jia-Ju Bai)"

* tag 'auxdisplay-for-linus-v4.19' of git://github.com/ojeda/linux:
  auxdisplay: simplify getting .drvdata
  auxdisplay: charlcd: delete mdelay in long_sleep
  • Loading branch information
torvalds committed Aug 16, 2018
2 parents 70b20dd + ada953d commit 25ca1d7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
6 changes: 2 additions & 4 deletions drivers/auxdisplay/arm-charlcd.c
Original file line number Diff line number Diff line change
Expand Up @@ -331,8 +331,7 @@ static int __init charlcd_probe(struct platform_device *pdev)

static int charlcd_suspend(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
struct charlcd *lcd = platform_get_drvdata(pdev);
struct charlcd *lcd = dev_get_drvdata(dev);

/* Power the display off */
charlcd_4bit_command(lcd, HD_DISPCTRL);
Expand All @@ -341,8 +340,7 @@ static int charlcd_suspend(struct device *dev)

static int charlcd_resume(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
struct charlcd *lcd = platform_get_drvdata(pdev);
struct charlcd *lcd = dev_get_drvdata(dev);

/* Turn the display back on */
charlcd_4bit_command(lcd, HD_DISPCTRL | HD_DISPCTRL_ON);
Expand Down
5 changes: 1 addition & 4 deletions drivers/auxdisplay/charlcd.c
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,7 @@ static atomic_t charlcd_available = ATOMIC_INIT(1);
/* sleeps that many milliseconds with a reschedule */
static void long_sleep(int ms)
{
if (in_interrupt())
mdelay(ms);
else
schedule_timeout_interruptible(msecs_to_jiffies(ms));
schedule_timeout_interruptible(msecs_to_jiffies(ms));
}

/* turn the backlight on or off */
Expand Down

0 comments on commit 25ca1d7

Please sign in to comment.