Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Kudu scanner should be allowed to do non-share scan. #53123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jcnessss
Copy link
Contributor

@Jcnessss Jcnessss commented Nov 22, 2024

Why I'm doing:

For now, all scanners generated by HiveDataSource are not allowed to do non-share scan. It makes sense for file scans since the size of each file might diff a lot. But the sizes of the tablets in kudu are basically the same, so we should try to assign morsel uniformly among operators to avoid data skew (showed below).

Kudu scan:
image

the following project:
image

What I'm doing:

Allow non-share scan in kudu connector.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@Jcnessss Jcnessss requested a review from a team as a code owner November 22, 2024 03:47
@Jcnessss Jcnessss force-pushed the kudu_individual_scan branch 10 times, most recently from f724591 to 88d0715 Compare November 27, 2024 06:47
@Jcnessss Jcnessss force-pushed the kudu_individual_scan branch from 88d0715 to db615d4 Compare November 27, 2024 07:54
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 9 / 9 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/connector_scan_node.cpp 4 4 100.00% []
🔵 be/src/connector/hive_connector.cpp 3 3 100.00% []
🔵 be/src/connector/lake_connector.h 1 1 100.00% []
🔵 be/src/connector/connector.h 1 1 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant