[BugFix] Publish time should be update in shared data #53209
+63
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smartlxh <[email protected]>
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
| state.updatePublishTaskFinishTime(); | ||
| } | ||
| } | ||
|
|
||
| // a proxy method | ||
| public void afterVisible(TransactionStatus transactionStatus, boolean txnOperated) { | ||
| for (TransactionState transactionState : transactionStates) { |
There was a problem hiding this comment.
The most risky bug in this code is:
ConcurrentModificationException risk when iterating over transactionStates if it is modified elsewhere.
You can modify the code like this:
import java.util.concurrent.CopyOnWriteArrayList;
public void updateSendTaskTime() {
for (TransactionState state : new CopyOnWriteArrayList<>(transactionStates)) {
state.updateSendTaskTime();
}
}
public void updatePublishTaskFinishTime() {
for (TransactionState state : new CopyOnWriteArrayList<>(transactionStates)) {
state.updatePublishTaskFinishTime();
}
}This modification ensures a thread-safe iteration over transactionStates by using CopyOnWriteArrayList, which avoids ConcurrentModificationException since it makes a separate copy of the list during iteration.
kevincai
reviewed
Nov 26, 2024
fe/fe-core/src/main/java/com/starrocks/transaction/TransactionState.java
Outdated
Show resolved
Hide resolved
…State.java Co-authored-by: Kevin Cai <[email protected]> Signed-off-by: fgump <[email protected]>
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 5 / 8 (62.50%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
publishVersionFinishTimeandpublishVersionTimein TransacctionState should be updated when publish in shared dataWhat I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: