-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Refactor mv partition compensate #54387
Open
LiShuMing
wants to merge
1
commit into
StarRocks:main
Choose a base branch
from
LiShuMing:refactor_mv_compensation_v1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+826
−749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ks/sql/optimizer/rule/transformation/materialization/compensation/MVCompensationBuilder.java
Show resolved
Hide resolved
...ql/optimizer/rule/transformation/materialization/compensation/ExternalTableCompensation.java
Show resolved
Hide resolved
...starrocks/sql/optimizer/rule/transformation/materialization/compensation/OptCompensator.java
Show resolved
Hide resolved
Signed-off-by: shuming.li <[email protected]>
LiShuMing
force-pushed
the
refactor_mv_compensation_v1
branch
from
December 26, 2024 08:38
47f9187
to
bbc9a44
Compare
Quality Gate failedFailed conditions |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 315 / 419 (75.18%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Seaven
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Refactor mv partition compensation:
BaseCompensation
toTableCompensation
which specifics MV's ref-base-table's compensate.TableCompensation
which use unrefreshed partition ids/keys to deduce partition compensations, and later we can extends toPartitionRetentionTableCompensation
which is generated by mv'spartition_retention_condition
.(see: [Enhancement] [WIP] Support partition retention condition compensation in force_mv rewrite mode #54072)MVCompensationBuilder
into Olap/External table compensations.Fixes #53117
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: