Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support empty cluster_snapshot.yaml config file #54416

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

xiangguangyxg
Copy link
Contributor

@xiangguangyxg xiangguangyxg commented Dec 26, 2024

Why I'm doing:

Empty cluster_snapshot.yaml config file is not handled, if users give an empty cluster_snapshot.yaml to restore then fe will start failed.

What I'm doing:

Support empty cluster_snapshot.yaml config file.

Fixes #53867

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Copy link

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

fail : 1 / 3 (33.33%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/StarRocksFE.java 0 1 00.00% [185]
🔵 com/starrocks/lake/snapshot/ClusterSnapshotConfig.java 1 2 50.00% [246]

@kevincai kevincai enabled auto-merge (squash) December 27, 2024 02:48
@andyziye andyziye disabled auto-merge December 27, 2024 02:50
@andyziye andyziye merged commit 13d0296 into StarRocks:main Dec 27, 2024
75 of 76 checks passed
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 27, 2024
Copy link
Contributor

mergify bot commented Dec 27, 2024

backport branch-3.4

✅ Backports have been created

@xiangguangyxg xiangguangyxg deleted the fix_empty_config branch December 27, 2024 02:51
mergify bot pushed a commit that referenced this pull request Dec 27, 2024
maggie-zhu pushed a commit to maggie-zhu/starrocks that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shared-data mode support backup restore though automated snapshot
4 participants