[pull] main from openrewrite:main

[pull]

See Commits and Changes for more details.

---

Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Update the handling of thrown exceptions in JavaType.Method.

Bug Fixes:

• Fix a bug where thrown exceptions were incorrectly typed as FullyQualified instead of JavaType.

Enhancements:

• Improve the accuracy of JavaType.Method by adding declaredFormalTypeNames to distinguish between generic type variables declared by the method and those defined on a containing class.
• Refactor ReloadableJavaTypeMapping to use arrays for parameter names, improving performance.
• Simplify exception handling in ReloadableJavaTypeMapping by directly adding JavaType exceptions instead of checking for FullyQualified.
• Update JavaReflectionTypeMapping to use generic types for fields and exceptions, improving type accuracy.

Tests:

• Add tests for declared fields, parameterized classes, name shadowing, and generic exceptions.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request updates the handling of thrown exceptions in JavaType.Method and improves type mapping in ReloadableJavaTypeMapping.

Class diagram showing changes to JavaType.Method

classDiagram
    class Method {
        -Integer managedReference
        -long flagsBitMap
        -FullyQualified declaringType
        -String name
        -JavaType returnType
        -String[] parameterNames
        -JavaType[] parameterTypes
        -JavaType[] thrownExceptions
        -FullyQualified[] annotations
        -List~String~ defaultValue
        -String[] declaredFormalTypeNames
        +getThrownExceptions() List~JavaType~
        +withThrownExceptions(List~JavaType~) Method
    }
    note for Method "Changed thrownExceptions type from FullyQualified[] to JavaType[]
Added declaredFormalTypeNames field for tracking generic type variables"

Loading

Class diagram showing type comparison changes

classDiagram
    class TypeComparison {
        +equals(Object o) boolean
        +isAssignableTo(String fullyQualifiedName) boolean
        +isAssignableFrom(JavaType type) boolean
    }
    note for TypeComparison "Changed .equals() comparisons to == for enum types
Improved type comparison logic"

Loading

File-Level Changes

Change	Details	Files
Changed the type of thrownExceptions in JavaType.Method from FullyQualified[] to JavaType[]	The thrownExceptions field in JavaType.Method was changed from FullyQualified[] to JavaType[]. Updated constructors, setters, and withThrownExceptions method to reflect the type change. Added a field for declared formal type names to JavaType.Method. Added logic to populate declared formal type names in method types.	rewrite-java/src/main/java/org/openrewrite/java/tree/JavaType.java
Updated type mapping for thrown exceptions in ReloadableJavaTypeMapping	Removed unnecessary checks and casts when adding thrown exception types. Added logic to capture declared formal type parameters at the method level.	rewrite-java-8/src/main/java/org/openrewrite/java/ReloadableJava8TypeMapping.java rewrite-java-11/src/main/java/org/openrewrite/java/isolated/ReloadableJava11TypeMapping.java rewrite-java-17/src/main/java/org/openrewrite/java/isolated/ReloadableJava17TypeMapping.java rewrite-java-21/src/main/java/org/openrewrite/java/isolated/ReloadableJava21TypeMapping.java
Improved handling of generic exceptions in JavaTypeMappingTest	Added tests for generic exceptions. Added tests for declared formal type parameters.	rewrite-java-test/src/main/java/org/openrewrite/java/JavaTypeMappingTest.java
Fixed equals comparisons to use == instead of .equals() for enum and primitive types	Replaced .equals() with == for comparisons with enum and primitive types.	rewrite-hcl/src/main/java/org/openrewrite/hcl/HclTemplate.java rewrite-hcl/src/main/java/org/openrewrite/hcl/format/AttributeSpaceVisitor.java rewrite-hcl/src/main/java/org/openrewrite/hcl/format/BracketsVisitor.java rewrite-hcl/src/main/java/org/openrewrite/hcl/tree/Space.java rewrite-java/src/main/java/org/openrewrite/java/JavaPrinter.java rewrite-java/src/main/java/org/openrewrite/java/JavaVisitor.java rewrite-java/src/main/java/org/openrewrite/java/internal/template/JavaTemplateJavaExtension.java rewrite-java/src/main/java/org/openrewrite/java/style/Autodetect.java rewrite-java/src/main/java/org/openrewrite/java/tree/JavaCoordinates.java rewrite-java/src/main/java/org/openrewrite/java/tree/JavaType.java rewrite-java-8/src/main/java/org/openrewrite/java/Java8ParserInputFileObject.java rewrite-java-8/src/main/java/org/openrewrite/java/ReloadableJava8ParserVisitor.java rewrite-java-11/src/main/java/org/openrewrite/java/isolated/ReloadableJava11ParserInputFileObject.java rewrite-java-11/src/main/java/org/openrewrite/java/isolated/ReloadableJava11ParserVisitor.java rewrite-java-17/src/main/java/org/openrewrite/java/isolated/ReloadableJava17ParserInputFileObject.java rewrite-java-17/src/main/java/org/openrewrite/java/isolated/ReloadableJava17ParserVisitor.java rewrite-java-21/src/main/java/org/openrewrite/java/isolated/ReloadableJava21ParserInputFileObject.java rewrite-java-21/src/main/java/org/openrewrite/java/isolated/ReloadableJava21ParserVisitor.java rewrite-maven/src/main/java/org/openrewrite/maven/RemoveDependency.java rewrite-maven/src/main/java/org/openrewrite/maven/RemoveManagedDependency.java rewrite-maven/src/main/java/org/openrewrite/maven/RemoveRedundantDependencyVersions.java rewrite-maven/src/main/java/org/openrewrite/maven/internal/InsertDependencyComparator.java rewrite-core/src/main/java/org/openrewrite/config/YamlResourceLoader.java rewrite-core/src/main/java/org/openrewrite/SourceFileWithReferences.java rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParserVisitor.java rewrite-hcl/src/main/java/org/openrewrite/hcl/internal/HclPrinter.java rewrite-hcl/src/main/java/org/openrewrite/hcl/tree/HclCoordinates.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.