Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from openrewrite:main #38

Open
wants to merge 173 commits into
base: main
Choose a base branch
from
+25,304 −10,059
Open

[pull] main from openrewrite:main #38

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
173 commits
Select commit Hold shift + click to select a range
2586748
When resolving maven pom properties give system properties precedence.
sambsnyd Jan 16, 2025
6cd1e2a
Refactoring, extract normalizeNewLines() (#4904)
greg-at-moderne Jan 16, 2025
462dc74
Correct TOML table parsing (#4910)
knutwannheden Jan 16, 2025
36efb73
Add a test validation that execution context is not mutated during re…
sambsnyd Jan 16, 2025
68f86ee
Optionally update maven plugin version in ChangePluginGroupIdAndArtif…
JesseEstum Jan 16, 2025
1fd511c
Fix AddOrUpdateAnnotationAttribute unable to handle FieldAccess (#4898)
SiBorea Jan 16, 2025
3d9653d
Fixed missing version on multiple dependency management sections in m…
t-huebner-id Jan 16, 2025
a6afce0
Tweak AddDependency to be a bit more permissive when adding a depende…
sambsnyd Jan 16, 2025
c1b258e
Fix issue parsing string with Java8ReloadableParser (#4914)
rlsanders4 Jan 17, 2025
b7746cf
Groovy parser fail with single line comment (#4887)
jonesbusy Jan 17, 2025
b2a641d
YAML Parser not to take @variables@ in the middle of scalar (#4917)
greg-at-moderne Jan 17, 2025
fa191cb
Add missing `@Contract` to `ListUtils#map()` method
knutwannheden Jan 17, 2025
9ddbb83
Support JEP-441: Pattern Matching for switch for Java 21+ (#4661)
nielsdebruin Jan 17, 2025
1d96858
Pull up recipes from rewrite-migrate-java (#4918)
timtebeek Jan 17, 2025
afa160e
Autodetect formatting style of JSON code (#4916)
greg-at-moderne Jan 17, 2025
ca96499
Tweak PathUtils so that multi-segment paths can be negated
sambsnyd Jan 18, 2025
04cfcf5
Prevent NPE on test resources without Gradle project marker
timtebeek Jan 20, 2025
dd01ca4
Support Groovy methods declaring generic type parameters (#4923)
knutwannheden Jan 20, 2025
0b3dfb9
Fixing YAML handling of multiline literals in some cases (#4924)
greg-at-moderne Jan 20, 2025
d8971bf
Refactoring, renaming visitors not to use Java in their name (#4926)
greg-at-moderne Jan 20, 2025
5c787c4
Allow Groovy class to extend `groovy.lang.Script` (#4922)
knutwannheden Jan 20, 2025
d49141c
Remove now duplicate test
timtebeek Jan 20, 2025
675ca5f
Map compiler type information for `SwitchExpression` (#4929)
Laurens-W Jan 21, 2025
1f4956b
Add "acceptTransitive" parameter to recipes which add gradle plugins.
sambsnyd Jan 22, 2025
2aadb97
Catch corner case in Java `TabsAndIndentsVisitor`
knutwannheden Jan 22, 2025
354101d
Add backwards compatibility constructors (#4933)
knutwannheden Jan 22, 2025
11a0924
Correct signature of deprecated `J.Case` constructor
knutwannheden Jan 22, 2025
7661418
`TypeTable` as a substitute for packing whole jars into `META-INF/rew…
jkschneider Jan 22, 2025
7e6da9a
Remove duplicate newline at the end of JavaParser
timtebeek Jan 22, 2025
5eb553c
Do not remove print statements from tests for now
timtebeek Jan 22, 2025
eb24b12
Revert #4933 again
knutwannheden Jan 23, 2025
d10d0ec
Parse `.xmake.cfg` files as TOML
timtebeek Jan 23, 2025
c7a28a6
Support JEP-440: Pattern matching for Records (#4925)
Laurens-W Jan 23, 2025
4684213
Add annotation element values to type attribution model (#4746)
zexblue01 Jan 23, 2025
b3b0601
Evaluate all classpath resources, not just the first
timtebeek Jan 23, 2025
bf0519d
Refactoring, moving getStyle methods to Style.from (#4935)
greg-at-moderne Jan 23, 2025
ef2e4f3
ChangeDependencyConfiguration should only perform updates when the or…
shanman190 Jan 24, 2025
0d7aae2
Fix bug in `PackageMatcher` (#4942)
knutwannheden Jan 24, 2025
fae7885
Support annotations on nested classes in `AnnotationTemplateGenerator…
knutwannheden Jan 24, 2025
d71f13c
Adding ReplaceLegacyAttributeIndexSyntax (#4944)
greg-at-moderne Jan 24, 2025
04059ce
Allow `io.moderne` recipes to mutate the execution context
timtebeek Jan 24, 2025
8be0e58
`TypeUtils#isOfType()` should not compare annotations on methods (#4945)
knutwannheden Jan 24, 2025
d6d91ee
Implement `TypeUtils#isOfType()` for `JavaType.Annotation`
knutwannheden Jan 24, 2025
192b605
Autodetect formatting style of JSON code - continued (#4931)
greg-at-moderne Jan 24, 2025
990589c
Honoring useCRLF in WrappingAndBracesVisitor (#4946)
greg-at-moderne Jan 27, 2025
c1c7bd1
Compact `GitProvenance.Committer` representation (#4096)
knutwannheden Jan 27, 2025
e863370
Fix bug parsing Groovy constructor declarations (#4950)
knutwannheden Jan 27, 2025
33a50e3
Maven repository ordering should give precedence to Maven settings ov…
lkerford Jan 27, 2025
20abe8e
refactor: Update Gradle wrapper
shanman190 Jan 27, 2025
898f8fd
Merge provided and built MavenSettings (#4956)
kmccarp Jan 27, 2025
8d7bd6d
Limit unnecessary resolution of dependencies
sambsnyd Jan 28, 2025
7152d19
Check for "lombok.Generated" attribute instead of checking for the `G…
jevanlingen Jan 28, 2025
17f4944
Fix bug in handling default case in switch statement (#4960)
amishra-u Jan 28, 2025
8e469b2
Move testcase (#4963)
Laurens-W Jan 28, 2025
819d3a6
More robust Groovy parentheses handling (#4951)
knutwannheden Jan 28, 2025
5fc715c
Refactoring AutodetectTest to simplify getStyle (#4947)
greg-at-moderne Jan 28, 2025
ca32839
Add org.openrewrite.scheduling.workingDirectory message exception to …
bryceatmoderne Jan 28, 2025
82f9d9e
chore: update suppressions for 2025-01-22 report (#4969)
bryceatmoderne Jan 29, 2025
f37372e
Revert "Refactoring AutodetectTest to simplify getStyle (#4947)" (#4970)
greg-at-moderne Jan 29, 2025
35f0b0b
YAML - fixing handling of space before colon (#4967)
greg-at-moderne Jan 29, 2025
154eb91
Enhance RemoveRedundantDependencyVersions to remove unneeded dependen…
sambsnyd Jan 29, 2025
8894141
Use DependencyStringNotationConverter
sambsnyd Jan 29, 2025
9022048
Remove redundant recursion from removal of redundant dependency versions
sambsnyd Jan 29, 2025
ee348a0
Further tweaks because Shannon keeps pointing out small improvements …
sambsnyd Jan 29, 2025
7c98672
Applying JSON formatting to members of objects and arrays (#4953)
greg-at-moderne Jan 30, 2025
d33ff3f
Gradle wrapper scripts packed as resources (#4957)
jkschneider Jan 30, 2025
63c9526
Exclude parenthese determination from comments and string literals (#…
jevanlingen Jan 30, 2025
9869097
Applying code suggestions (#4973)
greg-at-moderne Jan 30, 2025
6f8e2ed
Add `FindParseFailures#createdAfter` option
knutwannheden Jan 31, 2025
9ce51b5
Add `ai` tld as a root category.
jkschneider Feb 1, 2025
4e28652
refactor: Find and replace OpenRewriteRecipeBestPractices
timtebeek Feb 3, 2025
c11da8d
Work around reported exception in AddAnnotationProcessor
sambsnyd Feb 3, 2025
cc2c498
Avoid unnecessary memory allocation when updating the GradleProject m…
sambsnyd Feb 4, 2025
0e095f6
Have casing match enum so we don't get jackson errors parameterizing …
sambsnyd Feb 4, 2025
2d9b7dc
Preserve spacing when merging flow style YAML (#4981)
BelmoMusta Feb 4, 2025
4b21518
Support duplicate static star imports for Groovy (#4982)
jevanlingen Feb 5, 2025
73c4416
Replace `NavigableMap<LineColumn, List<ASTNode>>` to `NavigableMap<Li…
jevanlingen Feb 5, 2025
d582345
Use `sourceStartsWith` to simplify visitClass (#4987)
jevanlingen Feb 5, 2025
5541466
Add null check for AddDependency (#4985)
SiBorea Feb 5, 2025
422c053
Enable Lombok by default on Java 11+ (#4989)
timtebeek Feb 5, 2025
01a3911
Run groovy tests on Java 8 as well
sambsnyd Feb 5, 2025
cd95e0e
Activated profiles should not always deactivate POM profiles that are…
crankydillo Feb 5, 2025
22179f5
Support duplicate star imports with comments (#4990)
jevanlingen Feb 6, 2025
c2531c7
Disable parentheses level discovery for method calls for groovy 2 (#4…
jevanlingen Feb 6, 2025
ec68384
Add `insertBefore` option to MergeYaml (#4992)
jevanlingen Feb 6, 2025
de2f512
Skip GitProvenance for bare repositories (#4994)
timtebeek Feb 7, 2025
d7933f9
Avoid junit-bom:5.12.0-M1 in rewrite-test
timtebeek Feb 7, 2025
332c700
Don't include diff in exception in `Result` (#4997)
kmccarp Feb 7, 2025
1cf7059
Fix `:rewrite-groovy:test` by adding missing `antlr4-runtime`
timtebeek Feb 7, 2025
21fd10b
Fix remaining test failures after adding `UnknownSourceFileChangeExce…
timtebeek Feb 7, 2025
cb6f10c
Use `pattern` operator for all possible string kinds (#4998)
jevanlingen Feb 7, 2025
b33def6
Groovy parser does not support annotations on variable declarations (…
jevanlingen Feb 7, 2025
98e1643
Mark VariableDeclarations.NamedVariable.getType() as nullable
timtebeek Feb 10, 2025
75b23c7
Conditionally validate `ReplaceStringLiteralWithConstant` args
timtebeek Feb 10, 2025
78a33e4
Restore `junit-bom:latest.release` now that RC1 works
timtebeek Feb 10, 2025
efb5882
Conditionally validate `ReplaceStringLiteralWithConstant` args
jevanlingen Feb 10, 2025
c50c746
Fixes potential `StringIndexOutOfBoundsException` in Java parser (#5003)
knutwannheden Feb 10, 2025
cdd9d4b
Disable `exactVersionMissingInMavenMetadata` due to `Service Unavaila…
timtebeek Feb 10, 2025
5d3d123
Validate written classes if enabled, and fix reported issues (#4999)
timtebeek Feb 10, 2025
3fca435
Fix npe in Java parsers (#5010)
jevanlingen Feb 11, 2025
7f51370
Disable Lombok support again (#5011)
jevanlingen Feb 11, 2025
b311d86
Fixing JavaTemplateParser wrt method arguments replacement - removing…
greg-at-moderne Feb 11, 2025
5c1516f
Add `@Contract` annotation to `SearchResult#found()` methods
knutwannheden Feb 11, 2025
10ab44a
Groovy: Support `super()` and `this()` calls (#5008)
knutwannheden Feb 11, 2025
ca54520
Fix FindMavenSettings and EffectiveMavenRepositories to use logic mor…
sambsnyd Feb 12, 2025
ee142f0
Make `UpgradeDependencyVersion` recipe runnable with defined reposito…
jevanlingen Feb 12, 2025
058101d
Add `@JsonCreator` annotation to `JavaType.Annotation`
knutwannheden Feb 12, 2025
e0de1a0
Declaring Maven Central as first repository for some of the tests (#5…
greg-at-moderne Feb 12, 2025
92eec1a
JMH Gradle plugin 0.7.3 (#5022)
greg-at-moderne Feb 12, 2025
83b6001
Use pre-release Lombok runtime dependency (#5013)
knutwannheden Feb 12, 2025
a4a70fd
Removing dependency on :rewrite-maven (#5024)
greg-at-moderne Feb 12, 2025
ab8e8d5
Add `ResolutionEventListener` event whenever a repository normalizati…
pstreef Feb 12, 2025
d48cb5e
Hardcode Lombok 1.18.37 version (#5025)
knutwannheden Feb 12, 2025
910d13a
Apply OpenRewriteRecipeBestPractices (#5027)
timtebeek Feb 12, 2025
41ebc40
Small code cleanups
knutwannheden Feb 12, 2025
7154d56
Create TypeTable entries for empty marker annotations (#5014)
timtebeek Feb 12, 2025
2d8c802
Avoid possible NPE in JavaSourceSet.gavFromPath.
sambsnyd Feb 12, 2025
9303439
Amending YAML parser to add support for tags (#4934)
greg-at-moderne Feb 13, 2025
4e1a9dd
Apply best practices
timtebeek Feb 13, 2025
33284be
Centralize Lombok initialization logic (#5033)
knutwannheden Feb 13, 2025
a6167e0
Never return input value from `annotationElementValue()`
knutwannheden Feb 13, 2025
45261ef
Fixing descriptions (#5035)
greg-at-moderne Feb 13, 2025
0689107
Fix bug in type mapper's `annotationElementValue()` method
knutwannheden Feb 13, 2025
7746b49
Add some more assertions to `arrayTypeAnnotationElementValues` test case
knutwannheden Feb 13, 2025
1ab1d9f
Allow for Lombok replacing the `JavaFileManager`
knutwannheden Feb 13, 2025
71f0051
adding PANIC to ctx mutation allowlist
nmck257 Feb 13, 2025
194b33d
Update Gradle FindPlugins to be able to search by class name
sambsnyd Feb 14, 2025
549df10
Apply OpenRewrite best practices
timtebeek Feb 14, 2025
f792159
Applying code suggestions (#5042)
greg-at-moderne Feb 14, 2025
ae54e14
Read all TypeTable `classpath.tsv.zip` files (#5043)
timtebeek Feb 14, 2025
91ddeaa
Do not reuse Reader to avoid duplicate elements
timtebeek Feb 14, 2025
abf5dd9
Support modifiers for Groovy method declaration parameters (#5045)
jevanlingen Feb 17, 2025
077727b
Groovy - fix support for import statements following multiline commen…
greg-at-moderne Feb 17, 2025
99e1666
fix: handle comment at the end of a method declaration (#4996)
auke- Feb 17, 2025
671d12a
Groovy Parser - Improve retrieval of modifiers (#5048)
jevanlingen Feb 17, 2025
ddf3270
Groovy: Support property expression in annotation values (#5004)
knutwannheden Feb 18, 2025
a8f2189
Upgrading Antlr to 4.13.2 (#5007)
greg-at-moderne Feb 18, 2025
dfae406
Add dependencies in JVMTestSuite dependency block (#5000)
MBoegers Feb 18, 2025
25b0827
Annotate `Json.Literal#value` as `@Nullable`
knutwannheden Feb 18, 2025
2c6cfda
Improve MergeYaml recipe (#5036)
jevanlingen Feb 18, 2025
c3c9ad6
Add missing `@Nullable` constraints to `MavenResolutionResult` model
knutwannheden Feb 18, 2025
94474fe
ANTLR 4.13.2 - continued (#5057)
greg-at-moderne Feb 18, 2025
05795eb
Annotate `Hcl.Literal#value` as `@Nullable` (#5056)
knutwannheden Feb 18, 2025
cb65fd0
Declare root project name (#5061)
gabrielfeo Feb 18, 2025
e372fee
Improve description of method pattern recipe options for agentic AI t…
jkschneider Feb 19, 2025
a614e7d
Remove obsolete test code (#5060)
greg-at-moderne Feb 19, 2025
e789117
Re-enable disabled test case (#5059)
greg-at-moderne Feb 19, 2025
c9b83ff
JavaTemplate don't use type params on matching method invocations (#5…
greg-at-moderne Feb 19, 2025
9c6fa98
Record a SourcesFileResults.Row for generated sources (#5064)
timtebeek Feb 19, 2025
29b8076
improvement (#5037)
BelmoMusta Feb 19, 2025
d57186d
Restore Yaml.* constructors without Tag for gradual adoption (#5068)
timtebeek Feb 19, 2025
5c5f097
Add `io.moderne` as root category, same as `org.openrewrite` (#5067)
timtebeek Feb 19, 2025
3185241
Accept `DeserializationError` marker in `Result` constructor (#5069)
knutwannheden Feb 20, 2025
83dcc7b
Skip `DeserializationError`s in `InMemoryLargeSourceSet#getChangeset()`
knutwannheden Feb 20, 2025
0081929
Add `@Builder.Default` to `ResolvedDependency#licenses` to avoid NPEs
knutwannheden Feb 20, 2025
eccbe82
Add `@Builder.Default` to `ResolvedPom#activeProfiles` to avoid NPEs
knutwannheden Feb 20, 2025
e971fd6
Correct handling of boolean literals in `JsonPath` grammar and matche…
knutwannheden Feb 20, 2025
81ba6ec
Improve performance by caching the handful of new LST elements this r…
sambsnyd Feb 20, 2025
8fd17b1
Remove explicit `ReplaceStringLiteralWithConstant` constructors
knutwannheden Feb 20, 2025
9e101dd
Also update `ReplaceStringLiteralWithConstantTest`
knutwannheden Feb 20, 2025
927957d
Adjust yet a few more `@Nullable` properties
knutwannheden Feb 20, 2025
69dd3c7
Declare `AlreadyReplaced#find` as `@Nullable`
knutwannheden Feb 20, 2025
ce34584
Make sure `JavaSourceSet#gavToTypes` is never `null`
knutwannheden Feb 20, 2025
d915aff
Java parsing fix for empty comment as last line (#5076)
greg-at-moderne Feb 21, 2025
0881cbd
Better serializability of `MavenResolutionResult`
knutwannheden Feb 21, 2025
0dc4b54
Exclude `MavenResolutionResult` from Javadoc
knutwannheden Feb 21, 2025
49855ca
Parser failures with unnecessary semicolons (#5063)
timtebeek Feb 21, 2025
217c918
Fixing handling of trailing empty single-line comment (#5077)
greg-at-moderne Feb 21, 2025
657b7c4
Polish `TomlParser`
knutwannheden Feb 21, 2025
13f3fe3
Correct `DeclarativeRecipeTest#precondition()` test case
knutwannheden Feb 21, 2025
8232792
Reformat the method pattern description to be more readable (#5084)
mike-solomon Feb 22, 2025
c3b2157
Add JsonPathMatcherTest demonstrating overly broad matching
sambsnyd Feb 22, 2025
135fa89
Simplify test case
sambsnyd Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: Find and replace OpenRewriteRecipeBestPractices 
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.text.FindAndReplace?organizationId=T3BlblJld3JpdGU%3D#defaults%3DW3sibmFtZSI6ImZpbmQiLCJ2YWx1ZSI6Im9yZy5vcGVucmV3cml0ZS5yZWNpcGVzLk9wZW5SZXdyaXRlQmVzdFByYWN0aWNlcyJ9LHsibmFtZSI6InJlcGxhY2UiLCJ2YWx1ZSI6Im9yZy5vcGVucmV3cml0ZS5yZWNpcGVzLnJld3JpdGUuT3BlblJld3JpdGVSZWNpcGVCZXN0UHJhY3RpY2VzIn1d

Co-authored-by: Moderne <[email protected]>
  • Loading branch information
@timtebeek @TeamModerne
2 people authored and app committed Feb 3, 2025
commit 4e28652d8927d19f39b4eb3c9ec44dcd22c527ab
2 changes: 1 addition & 1 deletion .github/workflows/receive-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ jobs:
upload-patch:
uses: openrewrite/gh-automation/.github/workflows/receive-pr.yml@main
with:
recipe: 'org.openrewrite.recipes.OpenRewriteBestPracticesSubset'
recipe: 'org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPracticesSubset'
2 changes: 1 addition & 1 deletion rewrite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# Any differences produced by this recipe will result in code suggestion comments on pull requests.
---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.recipes.OpenRewriteBestPracticesSubset
name: org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPracticesSubset
displayName: OpenRewrite best practices
description: Best practices for OpenRewrite recipe development.
recipeList:
Expand Down