STATFLO-1093 #16
Merged
STATFLO-1093 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sicsol
approved these changes
Sep 26, 2023
jcroll
approved these changes
Sep 26, 2023
| "private": true, | ||
| "dependencies": { | ||
| "@faker-js/faker": "^8.0.2", | ||
| "@statflo/ui": "^0.0.14", |
|
|
||
| import { useWidgetContext } from "../providers/WidgetProvider"; | ||
|
|
||
| const WidgetSchema = Yup.object().shape({ |
There was a problem hiding this comment.
I haven't heard of yup. Is it a form builder?
There was a problem hiding this comment.
It's a schema builder, which I am using for validating the form. It's what is recommended by Formik which is the form package that I am using.
There was a problem hiding this comment.
Cool. I'm a fan of form builders, I was wondering if there was any motivation to use on our react projects.
| widget?: Widget; | ||
| }; | ||
|
|
||
| const WidgetForm = ({ isEdit, widget }: WidgetFormProps) => { |
There was a problem hiding this comment.
Here you simulate the widget admin? I know you said you were attempting this, very nice.
There was a problem hiding this comment.
Yeah! It's basically a dumbed down version of widget admin so that it simulates what would actually be going on in the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.