-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix view controller containment #24
base: master
Are you sure you want to change the base?
Conversation
…w behind translucent nav bar iOS 7 style
+1 hope this gets merged soon |
+1 please merge this |
Great change. This fixed a problem I was having when the |
+1 |
+1 hope this fix the auto layout issue in child view controllers |
@jerrypainter, did it work for you? |
@ankorko I have not gone deep into this, but after your changes, setting the current page index does not work. ViewDidLoad is called only when the pages actually load and the [setupPagingProcess] is not called and the self.scrollview is not set, so the [pageViewController setCurrentIndex:1 animated:NO]; does not work based on the examples given by the demos from @StefanLage Might be worth checking out. |
@gmogames this PR is one year old. To be honest I will probably not look into it, all I can remember is that View Controller containment was not done properly. Feel free to propose a change if you figure it out! |
My proposed fix for #23. Besides using the View Controller Containment APIs, I have made the internal UIScrollview fullscreen, so that it extends behind the bar iOS 7 style.