Close logs pipes and catch write errors

Signed-off-by: Alexandr Morozov <[email protected]>
StevenLudwig · Sep 22, 2014 · a7ee201 · a7ee201
1 parent fd3f2e1
commit a7ee201
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/daemon/logs.go b/daemon/logs.go
@@ -114,12 +114,14 @@ func (daemon *Daemon) ContainerLogs(job *engine.Job) engine.Status {
 		errors := make(chan error, 2)
 		if stdout {
 			stdoutPipe := container.StdoutLogPipe()
+			defer stdoutPipe.Close()
 			go func() {
 				errors <- jsonlog.WriteLog(stdoutPipe, job.Stdout, format)
 			}()
 		}
 		if stderr {
 			stderrPipe := container.StderrLogPipe()
+			defer stderrPipe.Close()
 			go func() {
 				errors <- jsonlog.WriteLog(stderrPipe, job.Stderr, format)
 			}()

diff --git a/pkg/jsonlog/jsonlog.go b/pkg/jsonlog/jsonlog.go
@@ -40,6 +40,8 @@ func WriteLog(src io.Reader, dst io.Writer, format string) error {
 		if err != nil {
 			return err
 		}
-		fmt.Fprintf(dst, "%s", line)
+		if _, err := io.WriteString(dst, line); err != nil {
+			return err
+		}
 	}
 }