Fix istringstream read for readlines #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using operator>> on a istringstream, there is a chance that it will silently fail if the contents of the buffer have all already been read. This is not a major issue in most scenarios. However, in a situation like this, the while loop will read all of the lines in, get to the last line, and then (I believe, I'm not 100% sure on this) read the EOF but still continue into the loop. As a result, using operator>> with 'line' during the last iteration will fail and the contents of 'name', 'mass', and 'radius' will stay the same. Essentially, without the if-statement the last line will get printed twice. Since this code is used as an example for the robosim individual assignment, this is pertinent to fix before it gets used again. individual assignment
|
This may actually only be an issue with c-strings/char[]. I am looking at a version where a student used string for the variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using operator>> on a istringstream, there is a chance that it will
silently fail if the contents of the buffer have all already been read.
This is not a major issue in most scenarios. However, in a situation like
this, the while loop will read all of the lines in, get to the last
line, and then (I believe, I'm not 100% sure on this) read the EOF but
still continue into the loop. As a result, using operator>> with 'line'
during the last iteration will fail and the contents of 'name', 'mass',
and 'radius' will stay the same. Essentially, without the if-statement
the last line will get printed twice. Since this code is used as an
example for the robosim individual assignment, this is important to fix
before it gets used again.