Merge pull request Expensify#33209 from tienifr/fix/32750

Fix: Loading shows even though not found in `ProfilePage`

src/pages/ProfilePage.js

@@ -57,9 +57,6 @@ const propTypes = {
     /** Route params */
     route: matchType.isRequired,
 
-    /** Indicates whether the app is loading initial data */
-    isLoadingReportData: PropTypes.bool,
-
     /** Session info for the currently logged in user. */
     session: PropTypes.shape({
         /** Currently logged in user accountID */
@@ -72,7 +69,6 @@ const propTypes = {
 const defaultProps = {
     // When opening someone else's profile (via deep link) before login, this is empty
     personalDetails: {},
-    isLoadingReportData: true,
     session: {
         accountID: 0,
     },
@@ -125,7 +121,7 @@ function ProfilePage(props) {
 
     const isCurrentUser = props.session.accountID === accountID;
     const hasMinimumDetails = !_.isEmpty(details.avatar);
-    const isLoading = lodashGet(details, 'isLoading', false) || _.isEmpty(details) || props.isLoadingReportData;
+    const isLoading = lodashGet(details, 'isLoading', false) || _.isEmpty(details);
 
     // If the API returns an error for some reason there won't be any details and isLoading will get set to false, so we want to show a blocking screen
     const shouldShowBlockingView = !hasMinimumDetails && !isLoading;
@@ -288,9 +284,6 @@ export default compose(
         personalDetails: {
             key: ONYXKEYS.PERSONAL_DETAILS_LIST,
         },
-        isLoadingReportData: {
-            key: ONYXKEYS.IS_LOADING_REPORT_DATA,
-        },
         session: {
             key: ONYXKEYS.SESSION,
         },