Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FieldTypes] add vars option on DateTime & Twig field types #365

Open
wants to merge 1 commit into
base: 1.14
Choose a base branch
from

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Feb 18, 2025

Passing generic "vars" option on string & datetime fields could be useful.

->addField(
      StringField::create('contractNumber')
          ->setOption('vars', ['th_class' => 'text-end'])
  )

When using this grid on twig rendering, you can handle these vars.
But you can also define some vars on other rendering like a CLI rendering option that could be useful too.

@loic425 loic425 force-pushed the feature/add-vars-on-date-time-and-twig-field-types branch 2 times, most recently from 1e84f4b to 3f51cf8 Compare February 18, 2025 13:12
@loic425 loic425 marked this pull request as draft February 18, 2025 13:16
@loic425 loic425 force-pushed the feature/add-vars-on-date-time-and-twig-field-types branch 3 times, most recently from a2e0cb5 to 68a2e65 Compare February 18, 2025 13:31
@loic425 loic425 marked this pull request as ready for review February 18, 2025 13:31
@loic425 loic425 force-pushed the feature/add-vars-on-date-time-and-twig-field-types branch from 68a2e65 to 1be35a7 Compare February 18, 2025 13:34
@loic425 loic425 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants