Skip to content

Commit

Permalink
Fix import from Chrome Devtools performance tab in Chrome >= 114 (jlf…
Browse files Browse the repository at this point in the history 
…wong#422)

The file format uses by Chrome Devtools performance tab periodically changes. It uses the Chrome trace event format (https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/preview).

This format, however, has two different types: one is `TraceEvent[]`, the other is `{traceEvents: traceEvent[]}`. The importer for non-Chrome devtools profiles already handled this, but the one for Chrome Devtools didn't because Chrome < 114 never used it. It seems like they changed the file format. This PR addresses that change.

Fixes jlfwong#420
  • Loading branch information
@jlfwong
jlfwong authored Jun 4, 2023
1 parent 81a6f29 commit 8da9088
Show file tree
Hide file tree
Showing 5 changed files with 3,323 additions and 1 deletion.
Loading

0 comments on commit 8da9088

Please sign in to comment.