Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(tabby): disable debug symbols for dependencies #2391

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

boxbeam
Copy link
Contributor

@boxbeam boxbeam commented Jun 11, 2024

My build caches have been getting quite large, so I figured it might make sense to add this setting to disable debug symbols in dependency crates, since they will basically never be used. This reduces cache size by ~34%

@boxbeam boxbeam requested a review from wsxiaoys June 11, 2024 21:15
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.30%. Comparing base (06e0754) to head (3d8bfc1).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2391   +/-   ##
=======================================
  Coverage   57.29%   57.30%           
=======================================
  Files         164      164           
  Lines       14644    14659   +15     
=======================================
+ Hits         8391     8400    +9     
- Misses       6253     6259    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsxiaoys
Copy link
Member

wsxiaoys commented Jun 12, 2024

I'm still hesitating to disable all of them, some of external dependencies are still helpful to locates crashes / profiling, e.g tantivy.

Is there a way to create a white list?

@boxbeam
Copy link
Contributor Author

boxbeam commented Jun 12, 2024

Yes, we could do profile.dev.package.<name>.debug = 0 for each one we want to disable, though that might end up being a huge number of lines since we have ~700 dependencies and each individual line would probably make very little difference

@boxbeam
Copy link
Contributor Author

boxbeam commented Jun 12, 2024

Okay, looking more closely it seems like we actually can leave in the * rule and still enable debug symbols for individual dependencies, which is much better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants