fix running mypy from project directory #520
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: CI
yedpodtrzitko
approved these changes
Sep 25, 2024
|
Would this line in the workflow need to be changed to |
it can stay as is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, running mypy from the root directory of the repo would log errors, because mypy couldn't find the referenced implementations for import statements like this one:
from src.qt.ts_qt import QtDriver. This change tells mypy that it can find these implementations in thetagstudiodirectory.Fixing this is necessary for the MyPy Extension for VSCode to work and it shouldn't break the existing workflows since running mypy in the
tagstudiodirectory still yields the same results as before.