fix child error occurring before child variable assigned

src/browser/services/track.js

@@ -17,7 +17,7 @@ const appName = 'Rodeo',
   };
 
 let trackGA = createTrackGA({metricsUrl: 'https://ssl.google-analytics.com/collect'}),
-  trackYhat = createTrackGA({metricsUrl: 'https://analytics.yhat.com/collect'});
+  trackYhat = createTrackGA({metricsUrl: 'http://analytics.yhat.com/collect'});
 
 /**
  * @typedef {object} TrackingEvent

src/node/index.js

@@ -24,11 +24,9 @@ import applicationMenu from './application-menu.yml';
 // enable source-maps
 require('source-map-support').install();
 
-console.log('>???', args, {__dirname, __filename});
-
 const argv = args.getArgv(),
   log = require('./services/log').asInternal(__filename),
-  staticFileDir = path.resolve(__dirname),
+  staticFileDir = path.resolve(electron.app.getAppPath()),
   kernelClients = {},
   windowUrls = {
     mainWindow: 'main.html',
@@ -984,7 +982,7 @@ function attachAppEvents(app) {
   });
   app.on('window-all-closed', () => {
     log('info', 'onWindowAllClosed');
-    quitApplication();
+    return quitApplication();
   });
   app.on('ready', onReady);
 }
@@ -997,9 +995,4 @@ function startPlotServer() {
     .catch(error => log('critical', 'failure to start plot server', error));
 }
 
-module.exports.onCloseWindow = onCloseWindow;
-module.exports.onFiles = onFiles;
-module.exports.onPDF = onPDF;
-module.exports.onReady = onReady;
-
 startApp();

src/node/services/log.js

@@ -1,5 +1,3 @@
-'use strict';
-
 import _ from 'lodash';
 import electronWinstonTransport from './electron-winston-transport';
 import path from 'path';
@@ -16,8 +14,7 @@ let electronTransport = new winston.transports.ElectronLogger({
   }),
   consoleTransport = new winston.transports.Console({
     level: 'info',
-    colorize: true,
-    humanReadableUnhandledException: true
+    colorize: true
   }),
   fileTransport = new winston.transports.File({
     filename: path.join(require('os').homedir(), 'rodeo.log'),
@@ -39,6 +36,8 @@ let electronTransport = new winston.transports.ElectronLogger({
     exitOnError: false
   });
 
+// stop winston from interfering
+winston.exitOnError = false;
 winston.handleExceptions(transports);
 
 /**

src/node/services/processes.js

@@ -51,12 +51,12 @@ function create(cmd, args, options) {
 
   const errors = [],
     details = {cmd, args, options},
-    child = childProcess.spawn(cmd, args, options)
-      .on('error', error => {
-        errors.push(error);
-        errorInChild(child, error, details);
-      })
-      .on('close', (code, signal) => removeChild(child, _.assign({code, signal, errors}, details)));
+    child = childProcess.spawn(cmd, args, options);
+
+  child.on('error', error => {
+    errors.push(error);
+    errorInChild(child, error, details);
+  }).on('close', (code, signal) => removeChild(child, _.assign({code, signal, errors}, details)));
 
   addChild(child, details);
   return child;

webpack.main.config.js

@@ -62,8 +62,8 @@ module.exports = {
   },
   node: {
     // we want the real location of files on the server-side
-    __filename: false,
-    __dirname: false
+    __filename: true,
+    __dirname: true
   },
   plugins: [
     new webpack.optimize.OccurrenceOrderPlugin(),