docs(react-form): add form.handleSubmit in form-composition.md subscribe button #1521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGeniusProgrammer
changed the title
MrGeniusProgrammer
changed the title
MrGeniusProgrammer
changed the title
| @@ -124,7 +124,7 @@ function SubscribeButton({ label }: { label: string }) { | |||
| const form = useFormContext() | |||
| return ( | |||
| <form.Subscribe selector={(state) => state.isSubmitting}> | |||
| {(isSubmitting) => <button disabled={isSubmitting}>{label}</button>} | |||
| {(isSubmitting) => <button onClick={() => form.handleSubmit()} disabled={isSubmitting}>{label}</button>} | |||
There was a problem hiding this comment.
The button is called SubscribeButton which doesn't really explain the purpose it's used for in the example (it being a SubmitButton)
I think it would be good to rename the ccomponent to be a SubmitButton instead.
So since it's meant to be a Submit button based on the label and usage, how about making it a submit button?
Suggested change
| {(isSubmitting) => <button onClick={() => form.handleSubmit()} disabled={isSubmitting}>{label}</button>} | |
| {(isSubmitting) => <button type="submit" disabled={isSubmitting}>{label}</button>} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the docs does not clearly states that form.handleSubmit must be present in the subscribe button in form composition and will confuse many developers (and I did get confused). So with this it is clearly stated.