-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update queries.md #9590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update queries.md #9590
Conversation
WalkthroughUpdated documentation in the React queries guide to change the stated fetchStatus value for the fetching state from 'fetching' to 'fetching the data'. No other content or public APIs were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/framework/react/guides/queries.md
(1 hunks)
- `fetchStatus === 'fetching the data'` - The query is currently fetching. | ||
- `fetchStatus === 'paused'` - The query wanted to fetch, but it is paused. Read more about this in the [Network Mode](../network-mode.md) guide. | ||
- `fetchStatus === 'idle'` - The query is not doing anything at the moment. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Incorrect fetchStatus literal — should be 'fetching'
The valid fetchStatus values are exactly: 'fetching', 'paused', 'idle'. Changing the first bullet to "fetching the data" is incorrect and inconsistent with the rest of this page and the official docs. Please revert to 'fetching'. (tanstack.com)
Apply this diff:
- - `fetchStatus === 'fetching the data'` - The query is currently fetching.
+ - `fetchStatus === 'fetching'` - The query is currently fetching.
Run this to catch any similar regressions across the docs:
🏁 Script executed:
#!/bin/bash
# Find incorrect literals
rg -n -C2 "fetching the data|fetchStatus\s*===\s*['\"]fetching the data['\"]" docs
# Sanity-check all documented fetchStatus values
rg -n -C2 "fetchStatus\s*===\s*['\"](fetching|paused|idle)['\"]" docs
Length of output: 2011
Use the correct fetchStatus
literal: replace 'fetching the data'
with 'fetching'
The fetchStatus
property only supports the exact values 'fetching'
, 'paused'
, and 'idle'
. Update the first bullet in the Queries guide to match the official API.
- File:
docs/framework/react/guides/queries.md
Line: 123
Apply this diff:
- `fetchStatus === 'fetching the data'` - The query is currently fetching.
+ `fetchStatus === 'fetching'` - The query is currently fetching.
Verification with ripgrep shows this is the only occurrence of the incorrect literal in docs/
. No further changes needed.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- `fetchStatus === 'fetching the data'` - The query is currently fetching. | |
- `fetchStatus === 'paused'` - The query wanted to fetch, but it is paused. Read more about this in the [Network Mode](../network-mode.md) guide. | |
- `fetchStatus === 'idle'` - The query is not doing anything at the moment. | |
- `fetchStatus === 'fetching'` - The query is currently fetching. | |
- `fetchStatus === 'paused'` - The query wanted to fetch, but it is paused. Read more about this in the [Network Mode](../network-mode.md) guide. | |
- `fetchStatus === 'idle'` - The query is not doing anything at the moment. |
🤖 Prompt for AI Agents
In docs/framework/react/guides/queries.md around lines 123 to 126, the first
bullet uses the incorrect fetchStatus literal `'fetching the data'`; change it
to the exact supported literal `'fetching'` so the list reads `'fetching'`,
`'paused'`, and `'idle'` to match the official API and documentation.
test
Summary by CodeRabbit