-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR] Querydsl을 이용한 쿼리 최적화 #112
Conversation
…into refactor/#108-querydsl-optimization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나도 얼른 공부한다음 리팩토링 할 부분 보이면 그때 추가로 할게!!
수고했어~~
String cronExpression = String.format("0 %s %s * * ?", pc.getPushTime().getMinute(), pc.getPushTime().getHour()); | ||
// String cronExpression = String.format("*/20 * * * * *"); | ||
// String cronExpression = String.format("0 %s %s * * ?", pc.getPushTime().getMinute(), pc.getPushTime().getHour()); | ||
String cronExpression = String.format("*/20 * * * * *"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 이상태로 올라가면 안될거 같아요!
수정 부탁쓰~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어이쿠 오케이 !!!
} | ||
|
||
private BooleanExpression userIdEq(Long userId) { | ||
return userId != null ? user.id.eq(userId) : null; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이렇게 주석까지 남겨주니까 보기 너무 좋다~ 굿굿
def queryDslDir = "build/querydsl/generated" | ||
|
||
sourceSets { | ||
main.java.srcDirs += [queryDslDir] | ||
} | ||
|
||
//def queryDslDir = "build/querydsl/generated" | ||
// | ||
//sourceSets { | ||
// main.java.srcDirs += [queryDslDir] | ||
//} | ||
// | ||
//tasks.withType(JavaCompile) { | ||
// options.annotationProcessorGeneratedSourcesDirectory = file(queryDslDir) | ||
//} | ||
// | ||
//clean.doLast { | ||
// file(queryDslDir).deleteDir() | ||
//} | ||
tasks.withType(JavaCompile) { | ||
options.getGeneratedSourceOutputDirectory().set(file(queryDslDir)) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build.gradle에서도 설정해줘야 하는구나,, 수고했으!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기가 굉장히 빡셌음 ,, 노션에 정리해뒀으니 참고하세욥 !!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
우리는 멀티모듈이어서 강의랑 다르게 적용해야 했구나,,, 🤣
📌 관련 이슈
close #108
✨ 어떤 이유로 변경된 내용인지
🙏 검토 혹은 리뷰어에게 남기고 싶은 말