-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use all 50 reaction kill sounds, instead of only 3 #382
base: master
Are you sure you want to change the base?
Conversation
I lack context, the code looks good to me just looking at it. |
what exactly does this do? |
@velzie when using |
@@ -1797,7 +1797,7 @@ static void CG_FirePlayerStateEvents( void ) | |||
reactionKillsDelay += cg.realFrameTime * 1000; | |||
|
|||
if( reactionKillsDelay > cg_reactionKillsTimeout->integer ){ | |||
CG_SexedSound( cg.view.POVent, CHAN_ANNOUNCER, va( S_PLAYER_RKILL_1_to_2, ( 1+rand()%3 ) ), | |||
CG_SexedSound( cg.view.POVent, CHAN_ANNOUNCER, va( S_PLAYER_RKILL_1_to_50, ( 1+rand()%50 ) ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be 51?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the reaction kills used 3 voice lines, not 2 like it says so i guess whoever implemented them first didn't do it correctly 🤷
this is what caine mentioned: Models haven’t been made for the characters I had in mind |
@haha-goodone-lol Please squash these and add a meaningful commit message |
currently only 3 of the reaction kill sounds are used but there are 50 in the assets
this makes it so all 50 reaction kill sounds can be used