Skip to content
This repository has been archived by the owner on Aug 1, 2021. It is now read-only.

Ender Invasion #30

Merged
merged 50 commits into from
Dec 8, 2020
Merged

Ender Invasion #30

merged 50 commits into from
Dec 8, 2020

Conversation

mschae23
Copy link
Member

@mschae23 mschae23 commented Sep 6, 2020

When echerite ore is mined, some parts of the overworld get corrupted by The End. Endermen will not spawn before this. In hard difficulty, it will also spread.

Breaking Echerite Ore will start the ender invasion
(place a diamond block into every chunk as a placeholder)
to see if the ender invasion has been generated in a chunk already. Also removed the diamond block placeholder
plus added withered log to #logs tag
and renamed end cap's textures
and made end foam able to replace more blocks when it generates
That means that the player can't get to The End before they mine echerite ore
The newest version of Cardinal Components isn't compatible with 1.16.1 though
(and updated piglin bartering loot table)
They no longer require to spawn on ender invasion blocks; instead, it has to be inside of the ender invasion.
This means that it can't be exploited to have high endermen spawn rates outside of corrupted areas.
@mschae23 mschae23 added looking for feedback Looking for suggestions, opinions, ideas, etc. new feature New feature or request reviews needed This pull request needs reviews before merging and removed looking for feedback Looking for suggestions, opinions, ideas, etc. labels Oct 6, 2020
@mschae23 mschae23 added this to the Release 1.0.0 milestone Oct 29, 2020
@BeetMacol BeetMacol requested review from BeetMacol and removed request for FoundationGames November 10, 2020 20:40
.gitignore Outdated Show resolved Hide resolved
src/main/resources/assets/motherlode/lang/en_us.json Outdated Show resolved Hide resolved
@BeetMacol
Copy link
Contributor

Ender invasion will require some in-game testing before merging.

# Conflicts:
#	build.gradle
#	src/main/java/motherlode/core/MotherlodeClient.java
Copy link
Contributor

@BeetMacol BeetMacol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mschae23
Copy link
Member Author

mschae23 commented Nov 12, 2020

If anyone tests this out in-game, can they tell me if they also have the (integrated) server not responding to the client anymore after a while? Like no new chunks generating, commands not working, the world not saving if you quit to title screen, etc.

Because that would be a critical issue I would have to fix and I want to make sure it's not just my computer.

Edit: I think I fixed it.

@mschae23 mschae23 added the critical issues This still has critical issues that need to be fixed. Don't merge. label Nov 12, 2020
# Conflicts:
#	src/main/java/motherlode/core/MotherlodeClient.java
#	src/main/resources/assets/motherlode/lang/en_us.json
@mschae23 mschae23 removed the critical issues This still has critical issues that need to be fixed. Don't merge. label Nov 12, 2020
Copy link
Contributor

@legoatoom legoatoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine.
I only think the text appearing in chat when the invasion starts can be a little different.
Maybe advancement or text in the screen like how the bed shows it.

@legoatoom legoatoom added new feature New feature or request and removed new feature New feature or request labels Nov 28, 2020
@mschae23
Copy link
Member Author

mschae23 commented Dec 7, 2020

Sorry for the delay. I didn't have time to work on this last week.

@mschae23 mschae23 added last call Any objections should be raised now, as this is close to being merged. and removed reviews needed This pull request needs reviews before merging labels Dec 7, 2020
@mschae23 mschae23 merged commit 1edd5db into TeamMotherlode:master Dec 8, 2020
@mschae23 mschae23 removed the last call Any objections should be raised now, as this is close to being merged. label Dec 8, 2020
@mschae23 mschae23 deleted the ender-invasion branch December 19, 2020 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants