Skip to content

Commit

Permalink
devkit: Remove redundant subshell from probe commands
Browse files Browse the repository at this point in the history
  • Loading branch information
oleavr committed Oct 7, 2022
1 parent 2387459 commit 661ae9f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions releng/devkit.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def generate_header(package, frida_root, host, kit, flavor, umbrella_header_path
else:
rc = env_rc(frida_root, host, flavor)
header_dependencies = subprocess.run(
[f"(. \"{rc}\" && $CC $CFLAGS -E -M $($PKG_CONFIG --cflags {package}) \"{umbrella_header_path}\")"],
[f". \"{rc}\" && $CC $CFLAGS -E -M $($PKG_CONFIG --cflags {package}) \"{umbrella_header_path}\""],
shell=True,
capture_output=True,
encoding="utf-8",
Expand Down Expand Up @@ -322,7 +322,7 @@ def generate_library_unix(package, frida_root, host, flavor, output_dir, library
rc = env_rc(frida_root, host, flavor)
ar = probe_env(rc, "echo $AR")

library_flags = subprocess.run([f"(. \"{rc}\" && $PKG_CONFIG --static --libs {package})"],
library_flags = subprocess.run([f". \"{rc}\" && $PKG_CONFIG --static --libs {package}"],
shell=True,
capture_output=True,
encoding="utf-8",
Expand Down Expand Up @@ -591,7 +591,7 @@ def internal_arch_lib_path(name, frida_root, host):


def probe_env(rc, command):
return subprocess.run([ f"(. \"{rc}\" && {command})" ],
return subprocess.run([f". \"{rc}\" && {command}"],
shell=True,
capture_output=True,
encoding="utf-8",
Expand Down

0 comments on commit 661ae9f

Please sign in to comment.