Fix GCC7 build #36
Closed
Fix GCC7 build #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if (*pSlash != '\0') {
As it stands the body of that if will always execute and when there are
no encoding parameters ppEncodingParams will be returned as a pointer to
an empty string rather than as a null pointer
Signed-off-by: Peter Korsgaard <[email protected]>
[Retrieved from:
https://git.buildroot.net/buildroot/tree/package/mp4v2/0001-Fix-GCC7-build.patch]
Signed-off-by: Fabrice Fontaine <[email protected]>
|
True, this patch was required to build projects both on Arch Linux https://git.archlinux.org/svntogit/packages.git/plain/trunk/libmp4v2-c++11.patch?h=packages/libmp4v2, and in Nixpkgs ("master" store state of NixOS). You can see that Arch Linux and NixOS are the best downstream testing grounds, so with this patch package would be picked-up by all other distros. |
|
Fedora also uses this patch: https://src.fedoraproject.org/rpms/libmp4v2/raw/d7aeedabb/f/0004-Fix-GCC7-build.patch |
|
You can close this; it was already committed in 8d6307e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if (*pSlash != '\0') {
As it stands the body of that if will always execute and when there are
no encoding parameters ppEncodingParams will be returned as a pointer to
an empty string rather than as a null pointer
Signed-off-by: Peter Korsgaard [email protected]
[Retrieved from:
https://git.buildroot.net/buildroot/tree/package/mp4v2/0001-Fix-GCC7-build.patch]
Signed-off-by: Fabrice Fontaine [email protected]