src/mp4track.cpp: replace nullptr by NULL #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 15ec111 added code that uses nullptr. nullptr is C++11, it will break the build with gcc < 5. Semantically, NULL and nullptr are different, so should not be mixed. In this situation, m_File.FindAtom() indeed does not return nullptr, but NULL (on error, that is). Switch back to comparing against NULL. Fixes: - http://autobuild.buildroot.org/results/14937c96a82fb3d10e5d83bd7b2905b846fb09f9 [Retrieved from: https://git.buildroot.net/buildroot/tree/package/mp4v2/0002-src-mp4track.cpp-replace-nullptr-by-NULL.patch] Signed-off-by: Fabrice Fontaine <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 15ec111 added code that uses
nullptr.nullptris C++11, it will break the build with gcc < 5.Semantically,
NULLandnullptrare different, so should not be mixed. In this situation,m_File.FindAtom()indeed does not returnnullptr, butNULL(on error, that is).Switch back to comparing against
NULL.Fixes:
[Retrieved from:
https://git.buildroot.net/buildroot/tree/package/mp4v2/0002-src-mp4track.cpp-replace-nullptr-by-NULL.patch]
Signed-off-by: Fabrice Fontaine [email protected]