feat: Tracing接入 --story=121703175 #1260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZQHcode
reviewed
Feb 21, 2025
| enable: false | ||
| # service name of APM in bk-monitor | ||
| serviceName: |
| if len(segments) == 1 { | ||
| // Only the function name is present, no package or struct name | ||
| return "unknown", "unknown", segments[0] | ||
| } else if len(segments) == 2 { |
There was a problem hiding this comment.
直接if就好了，不需要else if，下面 else也不需要
| sdktrace "go.opentelemetry.io/otel/sdk/trace" | ||
| semconv "go.opentelemetry.io/otel/semconv/v1.26.0" | ||
| "go.opentelemetry.io/otel/trace" | ||
|
|
| sdktrace.WithBatcher(exporter), | ||
| sdktrace.WithResource(res), | ||
| } | ||
| if opt.Enabled { |
There was a problem hiding this comment.
这个逻辑是为了做什么呢，看现在的实现的话，能走到这个函数的都是true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.