Skip to content

Commit

Permalink
Dataframe v2: extensive test suite and associated bug fixes for all e…
Browse files Browse the repository at this point in the history
…xisting features (rerun-io#7587)

This implements an extensive test suite that makes sure that all
existing features of the dataframe API A) have their behavior fully
specified in code (so we can at list agree on how things work _right
now_) and B) that said behavior does in fact.. behave.

This unsurprisingly revealed many bugs, which this PR fixes.

The currently existing features are:
* filtered_index
* filtered_index_range
* view_contents
* selection

Tests will later be added for the following, yet to be implemented
features:
* filtered_index_values
* sampled_index_values
* filtered_point_of_view
* sparse_fill_strategy
  • Loading branch information
teh-cmc authored Oct 4, 2024
1 parent 82eb7b0 commit d8310c6
Show file tree
Hide file tree
Showing 4 changed files with 743 additions and 41 deletions.
2 changes: 2 additions & 0 deletions Cargo.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5061,7 +5061,9 @@ dependencies = [
"re_types",
"re_types_core",
"seq-macro",
"similar-asserts",
"thiserror",
"unindent",
]

[[package]]
Expand Down
2 changes: 1 addition & 1 deletion crates/store/re_chunk/src/transport.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ use crate::{Chunk, ChunkError, ChunkId, ChunkResult, RowId, TimeColumn};
/// This means we have to be very careful when checking the validity of the data: slipping corrupt
/// data into the store could silently break all the index search logic (e.g. think of a chunk
/// claiming to be sorted while it is in fact not).
#[derive(Debug)]
#[derive(Debug, Clone)]
pub struct TransportChunk {
/// The schema of the dataframe, and all chunk-level and field-level metadata.
///
Expand Down
3 changes: 3 additions & 0 deletions crates/store/re_dataframe2/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,6 @@ thiserror.workspace = true

[dev-dependencies]
re_types.workspace = true

similar-asserts.workspace = true
unindent.workspace = true
Loading

0 comments on commit d8310c6

Please sign in to comment.