Allow pathlib.Path values as input to Model construction #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, only string values could be used to specify the path to the input ONNX file. However, several Python programs use values of type `pathlib.Path`, which causes the model creation to silently fail in onnx-tool. This patch fixes the problem by allowing both string paths or `pathlib.Path` paths. Credit to @xich for discovering the problem!
|
Here is a script to reproduce the error: import onnx_tool
from pathlib import Path
model = onnx_tool.Model(Path("/tmp/model.onnx"))
print(model.graph) # AttributeError: 'Model' object has no attribute 'graph' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, only string values could be used to specify the
path to the input ONNX file. However, several Python programs use
values of type
pathlib.Path, which causes the model creation tosilently fail in onnx-tool. This patch fixes the problem by allowing
both string paths or
pathlib.Pathpaths.Credit to @xich for discovering the problem!